More-correct data migrations - #10590
Merged
Merged
Conversation
Contributor
Author
|
@muhammad-ammar @muzaffaryousaf @symbolist I'm sick to death of data migrations.... :) Help me make this the last change! |
Contributor
|
👍 |
There was a problem hiding this comment.
Why get_or_create after the check ?
We need to be sure the migrations will work even in the presence of data from the future. get_or_create is a problem, because if the data already exists, there could be more than one record, even if this migration only creates one.
nedbat
force-pushed
the
ned/dj18-fixed-data-migrations
branch
from
November 11, 2015 14:03
bffd5b7 to
e7fcc74
Compare
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be sure the migrations will work even in the presence of data
from the future. get_or_create is a problem, because if the data
already exists, there could be more than one record, even if this
migration only creates one.