-
Notifications
You must be signed in to change notification settings - Fork 27
[BB-6206] Introduce a Filter to hook into courseware XBlock rendering #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tecoholic
wants to merge
2
commits into
openedx:main
from
open-craft:tecoholic/BB-6206-edit-links-poc
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -422,3 +422,46 @@ def run_filter(cls, context, template_name): | |
| """ | ||
| data = super().run_pipeline(context=context, template_name=template_name) | ||
| return data.get("context"), data.get("template_name") | ||
|
|
||
|
|
||
| class XBlockRenderStarted(OpenEdxPublicFilter): | ||
| """ | ||
| Custom class to change the XBlock Fragment of the units before rendering it to response | ||
|
|
||
| Arguments: | ||
| context (dict): contains the full context object that will be rendered in the | ||
| template_name (str): path to the template being used for rendering the XBlock | ||
| defaults to `lms/templates/courseware/courseware-chromeless.html` | ||
| """ | ||
|
|
||
| filter_type = "org.openedx.learning.xblock.render.started.v1" | ||
|
|
||
| class RenderCustomReponse(OpenEdxFilterException): | ||
| """ | ||
| Custom class used to stop the XBlock rendering process | ||
| """ | ||
| def __init__(self, message, response=None): | ||
| """ | ||
| Override init that defines specific arguments used in the XBlock render process. | ||
|
|
||
| Arguments: | ||
| message: error message for the exception. | ||
| response: custom response which will be returned by the render_xblock view. | ||
| """ | ||
| super().__init__( message, response=response) | ||
|
|
||
| @classmethod | ||
| def run_filter(cls, block, context, template_name): | ||
| """ | ||
| Execute the filter with the context. | ||
|
|
||
| Arguments: | ||
| block (VerticalBlock): The VerticalBlock containing the XBlocks to be | ||
| rendered | ||
| context (dict): the xblock rendering context with fragment and all other | ||
| related values. | ||
| template_name (str): the name of the template that will render the final | ||
| view | ||
| """ | ||
| data = super().run_pipeline(block=block, context=context, template_name=template_name) | ||
| return data.get("context"), data.get("template_name") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And here you can follow this one |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know these kinds of warnings are cumbersome, but to mitigate them you can follow these tests examples