[BB-6206] Introduce a Filter to hook into courseware XBlock rendering - #35
Closed
tecoholic wants to merge 2 commits into
Closed
[BB-6206] Introduce a Filter to hook into courseware XBlock rendering#35tecoholic wants to merge 2 commits into
tecoholic wants to merge 2 commits into
Conversation
This was referenced Jun 24, 2022
Member
|
Thanks for your contribution! I'll be reviewing this as soon as possible :) |
Member
|
Hello! @tecoholic can you take a look into the failing tests? |
mariajgrimaldi
self-requested a review
July 1, 2022 14:31
Contributor
Author
|
@mariajgrimaldi Sure thing :) I will get them fixed and let you know. |
| message: error message for the exception. | ||
| response: custom response which will be returned by the render_xblock view. | ||
| """ | ||
| super().__init__( message, response=response) |
Member
There was a problem hiding this comment.
I know these kinds of warnings are cumbersome, but to mitigate them you can follow these tests examples
| view | ||
| """ | ||
| data = super().run_pipeline(block=block, context=context, template_name=template_name) | ||
| return data.get("context"), data.get("template_name") |
11 tasks
Contributor
Author
|
I am replacing this PR with #38 based on the feedback on the PoC. @mariajgrimaldi Thank you for your time and patience. I will ping you on the other PR once all the details are filled in. This time I have the proper docs and tests :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The PR introduces a new filter named
XBlockRenderStartedthat allows apps to modify the output of the XBlock using pipelines. The corresponding change in the platform is introduced in openedx/openedx-platform#30650JIRA:
OpenCraft JIRA - https://tasks.opencraft.com/browse/BB-6206
Dependencies:
Merge deadline: List merge deadline (if any)
Installation instructions:
Nothing specific
Testing instructions:
The example application using this Hook is implemented in openedx-edit-link and its PR contains the testing instructions.
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns:
None