arrow animation & fix for section title #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* on tap on current element in dropdown view hide the dropdown view without refreshing of content * added rotation animation for expandable cell arrow and for dropdown title arrow * set line limit for courseDropdownTitle to 1 line and added paddings
This was
linked to
issues
Dec 14, 2023
saeedbashir
reviewed
Dec 15, 2023
| }).padding(.top, isHorizontal ? 10 : 0) | ||
| Group { | ||
| NavigationBar( | ||
| title: isDropdownActive ? sequenceTitle : "", |
There was a problem hiding this comment.
The screen title is missing when the drop-down isn't active which isn't the desired behavior.
There was a problem hiding this comment.
Hi, @saeedbashir, the original upstream develop doesn't contain title, so i moved it to under flag. Should i move it to persistent state @volodymyr-chekyrta ?
There was a problem hiding this comment.
Hi, @saeedbashir, the original upstream develop doesn't contain title, so i moved it to under flag
If thats the case, you can ignore this request. I thought it got missed because of our recent work.
There was a problem hiding this comment.
@saeedbashir, now menu is hide when user scrolls content
rnr
approved these changes
Dec 15, 2023
volodymyr-chekyrta
approved these changes
Dec 18, 2023
saeedbashir
pushed a commit
to saeedbashir/openedx-app-ios
that referenced
this pull request
Jan 5, 2024
* fix: contains next fixes: * on tap on current element in dropdown view hide the dropdown view without refreshing of content * added rotation animation for expandable cell arrow and for dropdown title arrow * set line limit for courseDropdownTitle to 1 line and added paddings * fix: hide dropdown when user is scrolling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR contains two tickets:
Previews:
[iOS] Fix section title displayed in two lines #208 & [iOS] Long section name is partially overlapped by navigation buttons #205
[iOS] Improve arrow animation for section drop-down and sequence nested lists #207
Simulator.Screen.Recording.-.iPhone.15.-.2023-12-14.at.16.26.28.mp4
Simulator.Screen.Recording.-.iPhone.15.-.2023-12-14.at.16.40.20.mp4