-
Notifications
You must be signed in to change notification settings - Fork 140
feat: updating help buttons links and texts #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
62b99ef
ab2f3c6
584178a
10f599e
cc57bf0
6696fba
988de34
77b61d0
399310f
b5b885b
35645f0
dd3912b
5753267
a08c0e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,8 +28,8 @@ describe('HelpContent', () => { | |
| it('renders all help buttons', () => { | ||
| const config = { SUPPORT_EMAIL: '[email protected]' }; | ||
| render(<ContentWithContext config={config} />); | ||
| expect(screen.getByText(messages.edxDocumentationButtonLabel.defaultMessage)).toBeInTheDocument(); | ||
| expect(screen.getByText(messages.edx101ButtonLabel.defaultMessage)).toBeInTheDocument(); | ||
| expect(screen.getByText(messages.educatorsDocsButtonLabel.defaultMessage)).toBeInTheDocument(); | ||
| expect(screen.getByText(messages.openEdxDemoCourseButtonLabel.defaultMessage)).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('does not render contact button if SUPPORT_EMAIL is empty', () => { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,25 +11,15 @@ const messages = defineMessages({ | |
| defaultMessage: 'Hide Studio help', | ||
| description: 'Label for button that closes the collapsed section with help buttons', | ||
| }, | ||
| edxDocumentationButtonLabel: { | ||
| id: 'authoring.footer.help.edxDocumentation.button.label', | ||
| defaultMessage: 'edX documentation', | ||
| description: 'Label for button that links to the edX documentation site', | ||
| educatorsDocsButtonLabel: { | ||
| id: 'authoring.footer.help.educatorsDocs.button.label', | ||
| defaultMessage: 'Open edX Educators Docs', | ||
| description: 'Label for button that links to the build a course quickstart site', | ||
| }, | ||
| openEdxPortalButtonLabel: { | ||
| openEdxDemoCourseButtonLabel: { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is changing It seems like the meaning of this label is changing, so the id should change too.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thats correct, id changed. |
||
| id: 'authoring.footer.help.openEdxPortal.button.label', | ||
| defaultMessage: 'Open edX portal', | ||
| description: 'Label for button that links to the Open edX portal', | ||
| }, | ||
| edx101ButtonLabel: { | ||
| id: 'authoring.footer.help.edx101.button.label', | ||
| defaultMessage: 'Enroll in edX 101', | ||
| description: 'Label for button that links to the edX 101 course', | ||
| }, | ||
| studioXButtonLabel: { | ||
| id: 'authoring.footer.help.studioX.button.label', | ||
| defaultMessage: 'Enroll in StudioX', | ||
| description: 'Label for button that links to the edX StudioX course', | ||
| defaultMessage: 'Open edX Demo Course', | ||
| description: 'Label for button that links to the open edX demo course portal', | ||
| }, | ||
| contactUsButtonLabel: { | ||
| id: 'authoring.footer.help.contactUs.button.label', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its intentional to add a sandbox link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these are the proposed links openedx/platform-roadmap#440 (comment)