Skip to content

Conversation

@jacobo-dominguez-wgu
Copy link
Contributor

platform-roadmap-Issue#440
frontend-app-authoring-Issue#978

Description

  • Updates the texts and links to the buttons from the help section, removing the ones with deprecated resources.
Captura de pantalla 2025-05-15 a la(s) 2 54 44 p m

This is the continuation for this pr #530

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 30, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.04%. Comparing base (281b817) to head (a08c0e1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          14       14           
  Lines          84       84           
  Branches       18       18           
=======================================
  Hits           79       79           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Needs Triage to Product Review in Contributions May 30, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Product Review to Ready for Review in Contributions May 30, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu requested a review from a team May 30, 2025 18:07
@jacobo-dominguez-wgu jacobo-dominguez-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label May 30, 2025
{
as: 'a',
href: 'https://openedx.org/',
href: 'https://sandbox.openedx.org/courses/course-v1:OpenedX+01-2024+2024-1/about',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its intentional to add a sandbox link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are the proposed links openedx/platform-roadmap#440 (comment)

description: 'Label for button that links to the build a course quickstart site',
},
openEdxPortalButtonLabel: {
openEdxDemoCourseButtonLabel: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is changing authoring.footer.help.openEdxPortal.button.label from being the "Label for button that links to the Open edX portal" to the "Label for button that links to the open edX demo course portal" intentional?

It seems like the meaning of this label is changing, so the id should change too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats correct, id changed.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brian-smith-tcril brian-smith-tcril merged commit db201af into openedx:master Jun 3, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants