-
Notifications
You must be signed in to change notification settings - Fork 140
feat: updating help buttons links and texts #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updating help buttons links and texts #535
Conversation
…om/jacobo-dominguez-wgu/frontend-component-footer into feat/update-footer-links-and-slots
…tend-component-footer into feat/update-footer-links-2
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 14 14
Lines 84 84
Branches 18 18
=======================================
Hits 79 79
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
| as: 'a', | ||
| href: 'https://openedx.org/', | ||
| href: 'https://sandbox.openedx.org/courses/course-v1:OpenedX+01-2024+2024-1/about', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its intentional to add a sandbox link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these are the proposed links openedx/platform-roadmap#440 (comment)
| description: 'Label for button that links to the build a course quickstart site', | ||
| }, | ||
| openEdxPortalButtonLabel: { | ||
| openEdxDemoCourseButtonLabel: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is changing authoring.footer.help.openEdxPortal.button.label from being the "Label for button that links to the Open edX portal" to the "Label for button that links to the open edX demo course portal" intentional?
It seems like the meaning of this label is changing, so the id should change too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats correct, id changed.
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
platform-roadmap-Issue#440
frontend-app-authoring-Issue#978
Description
This is the continuation for this pr #530