feat: Add Sidebar and SidebarNotificationButton components for Value Prop - #414
Conversation
…st to mock useWindowSize
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 82.01% 83.26% +1.24%
==========================================
Files 190 201 +11
Lines 3031 3442 +411
Branches 753 887 +134
==========================================
+ Hits 2486 2866 +380
- Misses 529 556 +27
- Partials 16 20 +4
Continue to review full report at Codecov.
|
4923832 to
3bf88c7
Compare
68be812 to
a44b20c
Compare
There was a problem hiding this comment.
No issues jump out at me- though I'm less familiar with this stuff so I'm not sure if they would.
One question would be around the unit test expectations: I see a couple lines flagged that aren't covered by unit tests yet. I that something that'll be included in this PR, or is it done more on a case-by-case basis for frontend-app-learning?
|
@dianekaplan good question, something I wonder too - overall test coverage went up with this PR and it does meet the minimum for merging, but not sure where to draw the line with UI tests to be honest. I can add some more if that's going to make the code more reliable |
jhan217
left a comment
There was a problem hiding this comment.
Looks fine to me, couple of minor comments
d4ab967 to
bc2e75f
Compare
This is a duplicate of https://github.com/edx/frontend-app-learning/pull/390, which has unknown build failures. This PR is the same but commit 68cf1db is divided up into separate commits here. More commits were added after commit 3bf88c7 Styling/a11y updates.
REV-2125.
For Value Prop implementation, we will implement a sidebar that is triggered on click of a button with upgrade messaging and CTA. Pls note this ticket does not cover adding the upgrade messaging and CTA, it only covers adding the button trigger and sidebar component.
Large screen size (> 992px):

Responsive at medium screen sizes (> 576px and < 992px): it has the button like large and above screen size, but the sidebar behaves in full width mode like for small screens.


Responsive at small screen sizes (< 576px):

