chore : removed reported_content_email_notifications_flag dependency - #775
Merged
Conversation
ayesha-waris
force-pushed
the
Ayesha/INF-1185
branch
3 times, most recently
from
January 4, 2024 14:18
d2108f8 to
320e766
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
==========================================
+ Coverage 89.56% 89.61% +0.05%
==========================================
Files 495 497 +2
Lines 8069 8109 +40
Branches 1697 1708 +11
==========================================
+ Hits 7227 7267 +40
Misses 815 815
Partials 27 27 ☔ View full report in Codecov by Sentry. |
sundasnoreen12
suggested changes
Jan 4, 2024
sundasnoreen12
left a comment
sundasnoreen12
left a comment
Contributor
There was a problem hiding this comment.
please remove reported_content_email_notifications_flag from
OpenedXConfigForm.test.jsx
src/pages-and-resources/discussions/factories/mockApiResponses.js
ayesha-waris
force-pushed
the
Ayesha/INF-1185
branch
from
January 5, 2024 08:37
320e766 to
c9b986e
Compare
awais-ansari
approved these changes
Jan 5, 2024
monteri
pushed a commit
to raccoongang/frontend-app-course-authoring
that referenced
this pull request
Jan 5, 2024
monteri
added a commit
to raccoongang/frontend-app-course-authoring
that referenced
this pull request
Jan 5, 2024
* chore: removed reported_content_email_notifications_flag dependency (openedx#775) * feat: [AXIMST-11] add functionality and tests for unit page header --------- Co-authored-by: ayesha waris <73840786+ayesha-waris@users.noreply.github.com> Co-authored-by: monteri <lansevermore>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INF-1185
Description
Removed
discussions.enable_reported_content_email_notificationsdependency in MFE