Skip to content

feat: error page on invalid course key - #761

Merged
KristinAoki merged 1 commit into
openedx:masterfrom
open-craft:artur/course-outline/error-page
Jan 4, 2024
Merged

feat: error page on invalid course key#761
KristinAoki merged 1 commit into
openedx:masterfrom
open-craft:artur/course-outline/error-page

Conversation

@ArturGaspar

Copy link
Copy Markdown
Contributor

Description

Shows a "Not found" page when an invalid course key is in the URL.
image

Testing instructions

  1. Open a course outline page
  2. Change the course key in the URL to a non-existent course
  3. See the not found page
  4. Open an editor page
  5. Change the course key (in the first component of the URL after /course/) to a non-existent course
  6. See the not found page

Deadline

None

Other information

Private-ref: https://tasks.opencraft.com/browse/BB-8262

@openedx-webhooks

openedx-webhooks commented Dec 21, 2023

Copy link
Copy Markdown

Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 21, 2023
@ArturGaspar
ArturGaspar force-pushed the artur/course-outline/error-page branch 2 times, most recently from 8037c3f to 0374f48 Compare December 21, 2023 17:26
@codecov

codecov Bot commented Dec 21, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (782fadd) 89.56% compared to head (56d53b4) 89.57%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
+ Coverage   89.56%   89.57%   +0.01%     
==========================================
  Files         495      496       +1     
  Lines        8069     8077       +8     
  Branches     1697     1700       +3     
==========================================
+ Hits         7227     7235       +8     
  Misses        815      815              
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArturGaspar
ArturGaspar force-pushed the artur/course-outline/error-page branch 3 times, most recently from f9139e2 to b0064d5 Compare December 21, 2023 17:54
@ArturGaspar
ArturGaspar marked this pull request as ready for review December 21, 2023 18:45
@ArturGaspar
ArturGaspar force-pushed the artur/course-outline/error-page branch from b0064d5 to 56d53b4 Compare December 21, 2023 19:12
@KristinAoki
KristinAoki merged commit 2e070c9 into openedx:master Jan 4, 2024
@openedx-webhooks

Copy link
Copy Markdown

@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@navinkarkera
navinkarkera deleted the artur/course-outline/error-page branch July 17, 2024 14:01
@navinkarkera
navinkarkera restored the artur/course-outline/error-page branch July 17, 2024 14:01
@navinkarkera
navinkarkera deleted the artur/course-outline/error-page branch July 17, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants