feat: update footer and header to use frontend-component version - #618
Merged
KristinAoki merged 3 commits intoOct 2, 2023
Merged
Conversation
KristinAoki
requested review from
connorhaugh,
jesperhodge,
kenclary and
rayzhou-bit
October 2, 2023 17:12
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 86.95% 86.81% -0.14%
==========================================
Files 386 378 -8
Lines 5758 5697 -61
Branches 1273 1258 -15
==========================================
- Hits 5007 4946 -61
Misses 729 729
Partials 22 22
☔ View full report in Codecov by Sentry. |
kenclary
approved these changes
Oct 2, 2023
KristinAoki
deleted the
KristinAoki/update-header-to-use-frontend-component-header
branch
October 2, 2023 19:06
snglth
pushed a commit
to Abstract-Tech/community-theme-course-authoring
that referenced
this pull request
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: TNL-10751
This PR removed the header and footer in this repo and replaces them with the ones from frontend-components-footer and frontend-components-header
Testing