Skip to content

feat: update footer and header to use frontend-component version - #618

Merged
KristinAoki merged 3 commits into
masterfrom
KristinAoki/update-header-to-use-frontend-component-header
Oct 2, 2023
Merged

feat: update footer and header to use frontend-component version#618
KristinAoki merged 3 commits into
masterfrom
KristinAoki/update-header-to-use-frontend-component-header

Conversation

@KristinAoki

@KristinAoki KristinAoki commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

JIRA Ticket: TNL-10751

  • The library-authoring header matches the header in course-authoring (non-xblock-editor pages) in style
  • We want the Library authoring header to look like the course authoring does.
  • We should make it easy for changes to the studio header to be reflected in any learning contexts. We should make a single source of truth for “studio headers.“
  • child components can be passed in to the shared component, injecting a different menu or other feature.
    • If possible frontend-component-header should be the place to make more flexible.

This PR removed the header and footer in this repo and replaces them with the ones from frontend-components-footer and frontend-components-header

Testing

  1. on home page and re-run page, header should only have studio icon and user menu
  2. on all other screens, the dropdowns should be as follows
    • Content
      • Outline
      • Updates
      • Pages & Resources
      • Files & Uploads
      • Video Uploads (if enabled)
    • Settings
      • Schedule & Details
      • Grading
      • Course Team
      • Group Configurations
      • Advanced Settings
      • Certificates
    • Tools
      • Import
      • Export
      • Checklist

@codecov

codecov Bot commented Oct 2, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0871ce3) 86.95% compared to head (543288a) 86.81%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   86.95%   86.81%   -0.14%     
==========================================
  Files         386      378       -8     
  Lines        5758     5697      -61     
  Branches     1273     1258      -15     
==========================================
- Hits         5007     4946      -61     
  Misses        729      729              
  Partials       22       22              
Files Coverage Δ
src/CourseAuthoringPage.jsx 96.15% <100.00%> (ø)
src/course-rerun/index.jsx 100.00% <ø> (ø)
src/header/Header.jsx 100.00% <100.00%> (ø)
src/header/messages.js 100.00% <ø> (ø)
src/header/utils.js 100.00% <100.00%> (ø)
src/studio-home/StudioHome.jsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki
KristinAoki merged commit 2a6a816 into master Oct 2, 2023
@KristinAoki
KristinAoki deleted the KristinAoki/update-header-to-use-frontend-component-header branch October 2, 2023 19:06
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants