Skip to content

fix: export and import UI bugs - #612

Merged
KristinAoki merged 10 commits into
masterfrom
KristinAoki/fix-export-import-ui-bugs
Sep 27, 2023
Merged

fix: export and import UI bugs#612
KristinAoki merged 10 commits into
masterfrom
KristinAoki/fix-export-import-ui-bugs

Conversation

@KristinAoki

Copy link
Copy Markdown
Contributor

JIRA Ticket: TNL-11052

  1. Change learn more button to link
  2. Main body text should be small
  3. Update alert modal component to include icon
  4. Fix header bottom margin
  5. Update icons to be CheckCircle when step completes for export/import
  6. Update table to take up full space of section
  7. Update success date and time to be localized
  8. fix wrapping on sidebar
  9. Move selected file message to top of import card
  10. Fix missing word studio in export and import sidebar messages

Testing

Import

  1. import a course to see the icons change from gears to CheckCircle
  2. Check the success time is not utc and matchs expected time zone.
  3. After import, the name of the imported file should appear above the dropzone area
  4. Check that the learn more text in the side bar is a link

Export

  1. export a course to see the icons change from gears to CheckCircle
  2. Check the success time is not utc and matchs expected time zone.
  3. Check that the learn more text in the side bar is a link

@codecov

codecov Bot commented Sep 27, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2ea876a) 86.61% compared to head (185c2fd) 86.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   86.61%   86.60%   -0.01%     
==========================================
  Files         386      386              
  Lines        5731     5743      +12     
  Branches     1256     1267      +11     
==========================================
+ Hits         4964     4974      +10     
- Misses        743      745       +2     
  Partials       24       24              
Files Coverage Δ
src/export-page/CourseExportPage.jsx 96.15% <ø> (ø)
src/export-page/export-footer/ExportFooter.jsx 100.00% <100.00%> (ø)
src/export-page/export-sidebar/ExportSidebar.jsx 100.00% <ø> (ø)
src/export-page/export-stepper/ExportStepper.jsx 96.42% <100.00%> (+0.42%) ⬆️
src/generic/course-stepper/index.jsx 100.00% <100.00%> (ø)
src/generic/modal-error/ModalError.jsx 100.00% <ø> (ø)
src/generic/sub-header/SubHeader.jsx 100.00% <100.00%> (ø)
src/import-page/CourseImportPage.jsx 95.23% <ø> (ø)
src/import-page/file-section/FileSection.jsx 92.85% <100.00%> (-0.48%) ⬇️
src/import-page/import-sidebar/ImportSidebar.jsx 100.00% <ø> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki
KristinAoki merged commit 887a628 into master Sep 27, 2023
@KristinAoki
KristinAoki deleted the KristinAoki/fix-export-import-ui-bugs branch September 27, 2023 16:10
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants