Skip to content

fix: studio home UI bugs - #611

Merged
KristinAoki merged 15 commits into
masterfrom
KristinAoki/fix-studi0-home-ui-bugs
Sep 28, 2023
Merged

fix: studio home UI bugs#611
KristinAoki merged 15 commits into
masterfrom
KristinAoki/fix-studi0-home-ui-bugs

Conversation

@KristinAoki

@KristinAoki KristinAoki commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

JIRA Ticket: TNL-11054

  1. Update re-run side bar section 1 description to use local time instead of UTC
  2. Make the error message in new course and course rerun forms font larger.
  3. Update colors used for error/denied, pending, and in-progress/unrequested card alerts
    i. error/denied - bg-danger-100 and text-gray-700
    ii. pending - bg-warning-100 and text-gray-700
    iii. in-progress - bg-light-100 and text-gray-700
  4. Add New library button that links to legacy library tab. When LA MFE is enabled it will direct to the create page
  5. Fix spacing and font size when using org search
  6. Update create course redirect to point at legacy outline page

Testing

Create Library

  1. Navigate to the home page
  2. Navigate to Django admin waffle flags and enable contentstore.split_library_on_studio_dashboard
  3. Click the "New library" button
  4. Should redirect to the legacy studio home with a focus on the library tab
  5. The address bar should read http://localhost:18010/home_library
  6. Navigate back to the studio home mfe
  7. Disable contentstore.split_library_on_studio_dashboard
  8. Click the "New library" button
  9. Should redirect to the legacy studio home with a focus on the library tab
  10. The address bar should read http://localhost:18010/home#libraries-tab
  11. Navigate to Django admin waffle flags and enable studio.library_authoring_mfe
  12. Click the "New library" button
  13. Should redirect to the library authoring mfe
  14. The address bar should read http://localhost:3001/create

Create course

  1. Click "New course"
  2. Fill out all of the information
  3. Click "Create course"
  4. Should be redirected to outline for new course

Rerun course

  1. Click "re-run course"
  2. Fill out all of the information
  3. Click "Create re-run"
  4. Should be redirected to outline for new course re-run

@KristinAoki
KristinAoki marked this pull request as ready for review September 26, 2023 17:28
@codecov

codecov Bot commented Sep 26, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c47c800) 86.45% compared to head (a9c239c) 86.92%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   86.45%   86.92%   +0.47%     
==========================================
  Files         372      386      +14     
  Lines        5580     5759     +179     
  Branches     1235     1275      +40     
==========================================
+ Hits         4824     5006     +182     
+ Misses        732      731       -1     
+ Partials       24       22       -2     
Files Coverage Δ
src/course-rerun/course-rerun-sidebar/index.jsx 100.00% <100.00%> (ø)
src/course-rerun/course-rerun-sidebar/messages.js 100.00% <ø> (ø)
src/course-rerun/index.jsx 100.00% <ø> (ø)
src/course-rerun/messages.js 100.00% <ø> (ø)
...xport-page/export-modal-error/ExportModalError.jsx 100.00% <100.00%> (ø)
...create-or-rerun-course/CreateOrRerunCourseForm.jsx 88.70% <ø> (+1.61%) ⬆️
...ate-or-rerun-course/factories/mockApiResponses.jsx 100.00% <100.00%> (ø)
src/generic/create-or-rerun-course/hooks.jsx 97.29% <100.00%> (+12.00%) ⬆️
src/studio-home/card-item/index.jsx 100.00% <ø> (ø)
...tudio-home/collapsible-state-with-action/index.jsx 94.73% <ø> (ø)
... and 7 more

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki
KristinAoki marked this pull request as draft September 26, 2023 17:46
@KristinAoki
KristinAoki marked this pull request as ready for review September 26, 2023 20:57

@jesperhodge jesperhodge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the test steps you described. Everything works except this: When I do "re-run course", I am always redirected to the home (overview) page, not to the course outline.

);
}

let libraryHref = `${getConfig().STUDIO_BASE_URL}/home#libraries-tab`;

This comment was marked as resolved.


let libraryHref = `${getConfig().STUDIO_BASE_URL}/home#libraries-tab`;
if (splitStudioHome) {
libraryHref = `${getConfig().STUDIO_BASE_URL}/home_library`;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
libraryHref = `${getConfig().STUDIO_BASE_URL}/home_library`;
libraryHref = `${getConfig()?.STUDIO_BASE_URL}/home_library`;

@KristinAoki
KristinAoki force-pushed the KristinAoki/fix-studi0-home-ui-bugs branch from f9a3de9 to a9c239c Compare September 28, 2023 21:28
@KristinAoki
KristinAoki merged commit 01ddac3 into master Sep 28, 2023
@KristinAoki
KristinAoki deleted the KristinAoki/fix-studi0-home-ui-bugs branch September 28, 2023 22:36
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants