Skip to content

fix: Text truncate issue in the search modal #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradenmacdonald merged 1 commit into from
Jun 13, 2025
Merged

fix: Text truncate issue in the search modal #2137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/search-modal/SearchModal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,13 @@
background-color: unset;
}
}

// Fix a bug with search modal: very long text is not truncated with an ellipsis
// https://github.com/openedx/frontend-app-authoring/issues/1900
.hit-description {
display: -webkit-box; /* stylelint-disable-line value-no-vendor-prefix */
-webkit-line-clamp: 1;
-webkit-box-orient: vertical;
overflow: hidden;
}
}
3 changes: 2 additions & 1 deletion src/search-modal/SearchResult.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ const SearchResult: React.FC<{ hit: ContentHit }> = ({ hit }) => {
<div className="hit-name small">
<Highlight text={hit.formatted.displayName} />
</div>
<div className="hit-description x-small text-truncate">
<div className="hit-description x-small">
<Highlight text={hit.formatted.content?.htmlContent ?? ''} />
<Highlight text={hit.formatted.content?.capaContent ?? ''} />
</div>
Expand All @@ -190,6 +190,7 @@ const SearchResult: React.FC<{ hit: ContentHit }> = ({ hit }) => {
</div>
</Stack>
<IconButton
className="flex-shrink-0"
src={OpenInNew}
iconAs={Icon}
onClick={openContextInNewWindow}
Expand Down