Skip to content

fix: Text truncate issue in the search modal - #2137

Merged
bradenmacdonald merged 1 commit into
openedx:masterfrom
raccoongang:fix/search-modal-text-truncate
Jun 13, 2025
Merged

fix: Text truncate issue in the search modal#2137
bradenmacdonald merged 1 commit into
openedx:masterfrom
raccoongang:fix/search-modal-text-truncate

Conversation

@bydawen

@bydawen bydawen commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Fixed issue with the text-truncate property, does not correctly applied to the description in the search result item in the search modal:
#1900

Replaced text-truncate class which contains white-space: nowrap; rule and in this case, it breaks layout.
Additionally fixed btn-icon that has shrunk due to lack of space.

Fix example:
Screenshot 2025-06-12 at 12 38 48

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bydawen!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 12, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 12, 2025
@bydawen
bydawen force-pushed the fix/search-modal-text-truncate branch from 0b36a5c to a3408b7 Compare June 12, 2025 12:57

@bradenmacdonald bradenmacdonald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Please just get the lint check passing and then I'll merge. You either need a comment to ignore the warning, or you can just omit the vendor prefixes and our CSS auto-prefixer will add them in for you. I'm not sure.

@bydawen
bydawen force-pushed the fix/search-modal-text-truncate branch from a3408b7 to d39c099 Compare June 13, 2025 07:43
@bydawen

bydawen commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for fixing this! Please just get the lint check passing and then I'll merge. You either need a comment to ignore the warning, or you can just omit the vendor prefixes and our CSS auto-prefixer will add them in for you. I'm not sure.

Thank you for review!

I kept the vendor-prefixed properties since line-clamp requires them to work, and added a linter ignore comment, by analogy with how it’s done here:

Screenshot 2025-06-13 at 10 43 06

@codecov

codecov Bot commented Jun 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.06%. Comparing base (c1d874f) to head (d39c099).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
+ Coverage   94.04%   94.06%   +0.01%     
==========================================
  Files        1163     1164       +1     
  Lines       24434    24443       +9     
  Branches     5186     5184       -2     
==========================================
+ Hits        22979    22992      +13     
+ Misses       1387     1383       -4     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradenmacdonald
bradenmacdonald merged commit fcf1e5c into openedx:master Jun 13, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Jun 13, 2025
@bradenmacdonald

Copy link
Copy Markdown
Contributor

Would you mind backporting this to Teak as well?

@bydawen

bydawen commented Jun 15, 2025

Copy link
Copy Markdown
Contributor Author

Would you mind backporting this to Teak as well?

Sure, here: #2151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants