fix: Text truncate issue in the search modal - #2137
Conversation
|
Thanks for the pull request, @bydawen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
0b36a5c to
a3408b7
Compare
bradenmacdonald
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Please just get the lint check passing and then I'll merge. You either need a comment to ignore the warning, or you can just omit the vendor prefixes and our CSS auto-prefixer will add them in for you. I'm not sure.
a3408b7 to
d39c099
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2137 +/- ##
==========================================
+ Coverage 94.04% 94.06% +0.01%
==========================================
Files 1163 1164 +1
Lines 24434 24443 +9
Branches 5186 5184 -2
==========================================
+ Hits 22979 22992 +13
+ Misses 1387 1383 -4
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would you mind backporting this to Teak as well? |
Sure, here: #2151 |

Fixed issue with the text-truncate property, does not correctly applied to the description in the search result item in the search modal:
#1900
Replaced
text-truncateclass which containswhite-space: nowrap;rule and in this case, it breaks layout.Additionally fixed
btn-iconthat has shrunk due to lack of space.Fix example:
