feat: allow pasting units from a course into a library - #1812
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
0d6d124 to
8010e99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1812 +/- ##
==========================================
+ Coverage 93.55% 93.56% +0.01%
==========================================
Files 1136 1136
Lines 23247 23252 +5
Branches 5029 5015 -14
==========================================
+ Hits 21748 21756 +8
+ Misses 1423 1420 -3
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0d26803 to
27b91a0
Compare
rpenido
left a comment
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @bradenmacdonald!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
27b91a0 to
70deca9
Compare
a0cd8bc to
1b32be2
Compare
Description
This PR allows pasting units from a course into a content library. The child XBlocks and the unit will be pasted into the library.
Depends on openedx/openedx-platform#36516
Note that if #1800 is not merged, you may see fake errors when copying.
Supporting information
Implemented as part of #1647 which turned out to be too complex so I started with the reverse.
Testing instructions
Go to a course, copy a unit, then test pasting that unit into both courses and libraries.
Also verify that the pasted things now have nice slugs (URL IDs / usage key block_ids) when pasted into a library.
Other information
It is a known issue that when copying a unit, all the static files referenced by any XBlock in the unit will be imported into the library separately for each XBlock. There is no good way to tell which static files are used by which XBlock (or maybe there is but it will have to come later as a fix; this PR is complicated enough already).
Private ref: Part of FAL-4067