fix: Copy to clipboard would seemingly fail even if it worked [FC-0083] - #1800
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
dde143f to
e0482ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1800 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 1136 1136
Lines 23241 23245 +4
Branches 5008 4913 -95
=======================================
+ Hits 21745 21749 +4
Misses 1428 1428
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b42a94b to
d71e1f7
Compare
e176578 to
d1eaf62
Compare
rpenido
left a comment
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @bradenmacdonald!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
|
Thanks! @ChrisChV could you please review as CC? |
|
@bradenmacdonald Looks good, could you fix the conflicts? |
d1eaf62 to
0e0db12
Compare
Description
When working on clipboard enhancements for containers, I noticed bugs with almost all of the "Copy to clipboard" actions in the MFE. They would work, but report an error that they failed, because the broadcast channel was closed.
Before:

After:

Testing instructions
Open library content and/or courses in the Authoring MFE. Try copying XBlocks or Units.
Make sure the sync among tabs is still working.
Other information
Private ref: Part of FAL-4067