Skip to content

fix: Copy to clipboard would seemingly fail even if it worked [FC-0083] - #1800

Merged
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:braden/fix-clipboard
Apr 15, 2025
Merged

fix: Copy to clipboard would seemingly fail even if it worked [FC-0083]#1800
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:braden/fix-clipboard

Conversation

@bradenmacdonald

Copy link
Copy Markdown
Contributor

Description

When working on clipboard enhancements for containers, I noticed bugs with almost all of the "Copy to clipboard" actions in the MFE. They would work, but report an error that they failed, because the broadcast channel was closed.

Before:
Screenshot showing an error

After:
Screenshot showing successfully copied

Testing instructions

Open library content and/or courses in the Authoring MFE. Try copying XBlocks or Units.

Make sure the sync among tabs is still working.

Other information

Private ref: Part of FAL-4067

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 9, 2025
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 9, 2025
@bradenmacdonald
bradenmacdonald requested a review from rpenido April 9, 2025 23:50
@bradenmacdonald
bradenmacdonald force-pushed the braden/fix-clipboard branch 2 times, most recently from dde143f to e0482ef Compare April 10, 2025 00:37
@codecov

codecov Bot commented Apr 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (a522c48) to head (0e0db12).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1800   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files        1136     1136           
  Lines       23241    23245    +4     
  Branches     5008     4913   -95     
=======================================
+ Hits        21745    21749    +4     
  Misses       1428     1428           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradenmacdonald
bradenmacdonald force-pushed the braden/fix-clipboard branch 2 times, most recently from b42a94b to d71e1f7 Compare April 11, 2025 23:02
@bradenmacdonald
bradenmacdonald force-pushed the braden/fix-clipboard branch 2 times, most recently from e176578 to d1eaf62 Compare April 12, 2025 00:06

@rpenido rpenido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @bradenmacdonald!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

Thanks! @ChrisChV could you please review as CC?

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Apr 14, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Apr 14, 2025
@ChrisChV

Copy link
Copy Markdown
Contributor

@bradenmacdonald Looks good, could you fix the conflicts?

@bradenmacdonald
bradenmacdonald enabled auto-merge (rebase) April 15, 2025 00:12
@bradenmacdonald
bradenmacdonald merged commit 6818542 into openedx:master Apr 15, 2025
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Apr 15, 2025
@bradenmacdonald
bradenmacdonald deleted the braden/fix-clipboard branch April 15, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants