Skip to content

build: use shared browserslist configuration - #607

Merged
mamankhan99 merged 2 commits into
masterfrom
maman/add-browserslist-config
Jun 29, 2022
Merged

build: use shared browserslist configuration#607
mamankhan99 merged 2 commits into
masterfrom
maman/add-browserslist-config

Conversation

@mamankhan99

Copy link
Copy Markdown
Contributor
  • Removes custom browserslist configuration in favor of using a shared configuration.
  • Removes is-es5 check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.

This change reduces the resultant asset bundle size.

@mamankhan99 mamankhan99 linked an issue Jun 13, 2022 that may be closed by this pull request
@codecov

codecov Bot commented Jun 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #607 (92ee4df) into master (c39fd33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   39.53%   39.53%           
=======================================
  Files         106      106           
  Lines        2188     2188           
  Branches      582      582           
=======================================
  Hits          865      865           
  Misses       1238     1238           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39fd33...92ee4df. Read the comment docs.

@jmbowman
jmbowman requested a review from a team June 14, 2022 02:51
@mamankhan99 mamankhan99 self-assigned this Jun 15, 2022

@davidjoy davidjoy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mamankhan99
mamankhan99 merged commit 1967199 into master Jun 29, 2022
@mamankhan99
mamankhan99 deleted the maman/add-browserslist-config branch June 29, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: use shared browserslist configuration

2 participants