Skip to content

build: use shared browserslist config - #545

Closed
adamstankiewicz wants to merge 2 commits into
masterfrom
astankiewicz/shared-browserslist-config
Closed

build: use shared browserslist config#545
adamstankiewicz wants to merge 2 commits into
masterfrom
astankiewicz/shared-browserslist-config

Conversation

@adamstankiewicz

@adamstankiewicz adamstankiewicz commented Nov 3, 2021

Copy link
Copy Markdown
Member
  • Removes custom browserslist configuration in favor of using a shared configuration.
  • Removes is-es5 check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.

This change reduces the resultant asset bundle size.

@adamstankiewicz
adamstankiewicz requested a review from a team November 3, 2021 04:34
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #545 (f19d22b) into master (a18daec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #545   +/-   ##
=======================================
  Coverage   40.78%   40.78%           
=======================================
  Files         107      107           
  Lines        2236     2236           
  Branches      604      604           
=======================================
  Hits          912      912           
  Misses       1240     1240           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18daec...f19d22b. Read the comment docs.

@Jawayria
Jawayria force-pushed the astankiewicz/shared-browserslist-config branch from f19d22b to 4d8151a Compare June 2, 2022 15:56
@codecov

codecov Bot commented Jun 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #545 (4d8151a) into master (c39fd33) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d8151a differs from pull request most recent head ba5456b. Consider uploading reports for the commit ba5456b to get more accurate results

@@           Coverage Diff           @@
##           master     #545   +/-   ##
=======================================
  Coverage   39.53%   39.53%           
=======================================
  Files         106      106           
  Lines        2188     2188           
  Branches      582      582           
=======================================
  Hits          865      865           
  Misses       1238     1238           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39fd33...ba5456b. Read the comment docs.

@davidjoy

davidjoy commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

Is this good to go? If so we can get it merged.

@abdullahwaheed

Copy link
Copy Markdown
Contributor

duplicates #607. closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants