Skip to content

[BD-21] Improve monitoring of legacy Waffle class imports #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regisb merged 1 commit into from
Dec 17, 2020
Merged

[BD-21] Improve monitoring of legacy Waffle class imports #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ Change Log

.. There should always be an "Unreleased" section for changes pending release.

[1.2.1] - 2020-12-17
~~~~~~~~~~~~~~~~~~~~

* Improve monitoring of legacy Waffle class imports. We should watch for "edx_toggles.toggles.internal.waffle.legacy.WaffleSwitch" custom attributes.


[1.2.0] - 2020-11-05
~~~~~~~~~~~~~~~~~~~~

Expand Down
2 changes: 1 addition & 1 deletion edx_toggles/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
Library and utilities for feature toggles.
"""

__version__ = '1.2.0'
__version__ = '1.2.1'

default_app_config = 'edx_toggles.apps.TogglesConfig' # pylint: disable=invalid-name
21 changes: 17 additions & 4 deletions edx_toggles/toggles/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,21 @@
from .internal.setting_toggle import SettingDictToggle, SettingToggle
from .internal.waffle.legacy import WaffleFlag, WaffleFlagNamespace, WaffleSwitch, WaffleSwitchNamespace


# Create waffle aliases for forward compatibility
LegacyWaffleFlag = WaffleFlag
LegacyWaffleFlagNamespace = WaffleFlagNamespace
LegacyWaffleSwitch = WaffleSwitch
LegacyWaffleSwitchNamespace = WaffleSwitchNamespace
# We create new classes instead of using `LegacyClass = Class` statements
# for better monitoring of legacy class usage.
class LegacyWaffleFlag(WaffleFlag):
pass


class LegacyWaffleFlagNamespace(WaffleFlagNamespace):
pass


class LegacyWaffleSwitch(WaffleSwitch):
pass


class LegacyWaffleSwitchNamespace(WaffleSwitchNamespace):
pass