[BD-21] Improve monitoring of legacy Waffle class imports - #98
Merged
Conversation
|
Thanks for the pull request, @regisb! I've created BLENDED-685 to keep track of it in Jira. More details are on the BD-21 project page. When this pull request is ready, tag your edX technical lead. |
openedx-webhooks
added
blended
10 tasks
regisb
force-pushed
the
regisb/improve-waffle-monitoring
branch
2 times, most recently
from
December 17, 2020 15:26
17e6c19 to
9c6806f
Compare
robrap
reviewed
Dec 17, 2020
We should watch for
"edx_toggles.toggles.internal.waffle.legacy.WaffleSwitch"
custom attributes. Wherever those occur, we should replace:
from edx_toggles.toggles import WaffleFlag/WaffleSwitch
by:
from edx_toggles.toggles import LegacyWaffleFlag/LegacyWaffleSwitch
This will ensure forward compatibility with edx-toggles==2.0.0.
regisb
force-pushed
the
regisb/improve-waffle-monitoring
branch
from
December 17, 2020 15:48
9c6806f to
1aac473
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should watch for "edx_toggles.toggles.waffle.internal.legacy.WaffleSwitch"
custom attributes. Wherever those occur, we should replace:
by:
This will ensure forward compatibility with edx-toggles==2.0.0.
Description: Describe in a couple of sentence what this PR adds
JIRA: https://openedx.atlassian.net/wiki/spaces/COMM/pages/1596358943/BD-21+Toggles+Settings+Documentation
Reviewers:
Merge checklist:
Documentation updated (not only docstrings)Post merge:
finished.