[BD-21] Fix SettingDictToggle constructor - #71
Closed
regisb wants to merge 1 commit into
Closed
Conversation
The constructor was missing the `module_name` argument.
openedx-webhooks
added
blended
|
Thanks for the pull request, @regisb! I've created BLENDED-629 to keep track of it in Jira. More details are on the BD-21 project page. When this pull request is ready, tag your edX technical lead. |
Contributor
Author
|
@robrap FYI this should be pretty quick to review. |
Contributor
Author
|
Closed in favour of #70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The constructor was missing the
module_nameargument.JIRA: https://openedx.atlassian.net/wiki/spaces/COMM/pages/1596358943/BD-21+Toggles+Settings+Documentation
Reviewers:
Merge checklist:
Documentation updated (not only docstrings)Post merge:
finished.