[BD-21] Use edx-toggle's SettingDictToggle to document setting-based feature toggles - #25332
Merged
Conversation
openedx-webhooks
added
blended
|
Thanks for the pull request, @regisb! I've created BLENDED-630 to keep track of it in Jira. More details are on the BD-21 project page. When this pull request is ready, tag your edX technical lead. |
Contributor
Author
|
The tests are failing because edx-toggles needs some of the commits from openedx/edx-toggles#70. Otherwise this is ready for review @robrap. |
regisb
force-pushed
the
regisb/use-settingdict
branch
3 times, most recently
from
October 14, 2020 09:25
d96b10b to
46582c4
Compare
Contributor
Author
|
Why am I getting quality warnings from portions of files which I did not touch? |
regisb
force-pushed
the
regisb/use-settingdict
branch
from
October 14, 2020 10:47
46582c4 to
34cfaef
Compare
robrap
reviewed
Oct 14, 2020
regisb
force-pushed
the
regisb/use-settingdict
branch
from
October 15, 2020 10:21
34cfaef to
491ef22
Compare
robrap
reviewed
Oct 15, 2020
regisb
force-pushed
the
regisb/use-settingdict
branch
3 times, most recently
from
October 22, 2020 19:22
6d69b30 to
6ebec58
Compare
robrap
reviewed
Oct 22, 2020
robrap
reviewed
Oct 24, 2020
regisb
force-pushed
the
regisb/use-settingdict
branch
from
October 29, 2020 10:12
6ebec58 to
daef264
Compare
|
Your PR has finished running tests. There were no failures. |
robrap
approved these changes
Oct 29, 2020
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
Confirming that this is ready to merge on your end as well. If so, I will merge this in the morning.
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on openedx/edx-toggles#70 (merged)
Note that here we only document feature toggles, but we don't expose them (yet) as part of the feature toggle API.
Here we document the following setting toggles:
cc @robrap