Move "deleted" submissions to separate table - #36
Closed
efischer19 wants to merge 2 commits into
Closed
Conversation
| migrations.CreateModel( | ||
| name='SubmissionDeleted', | ||
| fields=[ | ||
| ('submission_ptr', models.OneToOneField(parent_link=True, auto_created=True, primary_key=True, serialize=False, to='submissions.Submission')), |
Contributor
Author
There was a problem hiding this comment.
That's not right, delete() will cascade and get this too.
Hang on...
efischer19
force-pushed
the
efischer/archive_table
branch
from
February 9, 2016 14:33
cb334b9 to
0d2847b
Compare
efischer19
force-pushed
the
efischer/archive_table
branch
from
February 9, 2016 14:46
0d2847b to
9bb69ca
Compare
Contributor
Author
|
Aha! Finally got it work. I can confirm that this behaves as we want in ORA (submission becomes inaccessible both to staff tools and grading pools), and here's what the data looks like on the backend: |
This was referenced Feb 9, 2016
To fix the buggy behavior reported in TNL-3880, we need to ensure that the submission we're dropping is unlinked from the student_item used to find it. This prevents code (say, an ORA staff tool) from constructing a student item with an id, a course, and a problem, and using that to find a "cleared" submission. Also includes migration for adding SubmissionDeleted model
efischer19
force-pushed
the
efischer/archive_table
branch
from
February 10, 2016 14:47
481681f to
c0abeb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this option 4 in the "how should we soft delete
Submissions" balloting.Testing on my devstack now.