Clear Submission - #863
Conversation
71e0fcd to
4fe1044
Compare
4931424 to
25bebdd
Compare
|
|
||
| # edx-submissions | ||
| git+https://github.com/edx/edx-submissions.git@0.1.3#egg=edx-submissions==0.1.3 | ||
| git+https://github.com/edx/edx-submissions.git@efischer/soft_delete_sub#egg=edx-submissions |
There was a problem hiding this comment.
Also just for sandbox consistency; this will be a proper edx-submissions release version before merging.
|
This PR is ready for review. @cahrens and @dianakhuang, could you look it over when you get a chance? The sibling change for edx-platform is also ready for review, but the edx-submissions one is still undergoing devops vetting. Regardless of what we do there, the API connection point to ORA will remain the same. The behavior can be tested at https://efischer19.sandbox.edx.org/ |
|
|
||
| def clear_submission(self, user_id, course_id, item_id): | ||
| """ | ||
| This method is called to reset student state for a given problem. It will |
There was a problem hiding this comment.
Nit: Why is the comment text indented? It looks odd to me.
There was a problem hiding this comment.
Copied from cancel_submission, which does the same thing. I'll clean both of them up.
|
Initial feedback addressed. @robrap and @dianakhuang, this one is ready for review as well, but before it can merge, openedx/edx-submissions#33 will have to merge so the requirements in this PR can be properly updated |
| """ | ||
| This method is called to reset student state for a given problem. It will | ||
| cancel the workflow using traditional methods, to remove it from the grading pools, | ||
| and pass through to the submissions API to orphan the submission so the user can create a new one. |
There was a problem hiding this comment.
Assuming that this is the method signature set up by the LMS, you may want to make that more clear in the comment.
7f45006 to
48c7cc3
Compare
|
@robrap Initial comments have been addressed here as well. |
48c7cc3 to
106e53e
Compare
|
👍 Thanks for working toward a cleaner solution @efischer19. |
|
👍 from me as well. |
106e53e to
577b296
Compare
Remove a submission from ORA by cancelling it to remove from grading pools, then passing through to submissions.
577b296 to
6e1db5b
Compare
4 participants
Remove a submission from ORA by cancelling it to remove from grading
pools, then passing through to submissions.
Sibling changes:
Clear state option edx-submissions#34Superseded by Move "deleted" submissions to separate table edx-submissions#36Soft-delete Submissions to reset student state edx-submissions#33