-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOM-2247 - Upgrade pip-tools #27861
BOM-2247 - Upgrade pip-tools #27861
Conversation
c3ce33d
to
be457ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as long as you ran both make requirements
and make upgrade
after actually installing the new version to verify they still work.
Ok. Will verify. |
📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build. We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master. This branch has been detected to not have commit 2e33565 as an ancestor. Here's how to see for yourself:
If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal). |
075047a
to
c1e5bc4
Compare
Upgrade job was successful with changes at https://github.com/edx/edx-platform/runs/2828907489?check_suite_focus=true |
Your PR has finished running tests. There were no failures. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
* chore: upgrade pip-tools * replace --no-index with --no-emit-index-url * upgrade pip Co-authored-by: edX requirements bot <[email protected]>
Now that we are have pinned pip to version 20.3.4 in configuration, which is compatible with the latest version of pip-tools according to this compatibility chart
https://github.com/jazzband/pip-tools/#versions-and-compatibility
So in this PR, we are upgrading the latest pip-tools.
Also
pip-tools==6.0.0 removed
--index/--no-index
flag from pip-compile command.--index/--no-index
flag was deprecated in pip-tools==5.2.0 in favor of--emit-index-url/--no-emit-index-url
.Relevant JIRA: https://openedx.atlassian.net/browse/BOM-2247