Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated "--index/--no-index" option from compile command #1234

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Remove deprecated "--index/--no-index" option from compile command #1234

merged 2 commits into from
Mar 3, 2021

Conversation

jdufresne
Copy link
Member

@jdufresne jdufresne commented Nov 22, 2020 •
edited
Loading

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@jdufresne jdufresne added this to the 6.0.0 milestone Nov 22, 2020
@jdufresne jdufresne added the backwards incompatible Backwards incompatible change label Nov 22, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020 •
edited
Loading

Codecov Report

Merging #1234 (4b5ff05) into master (f54ad96) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files          33       33              
  Lines        2953     2926      -27     
  Branches      322      319       -3     
==========================================
- Hits         2942     2915      -27     
  Misses          5        5              
  Partials        6        6
Impacted Files Coverage Δ
tests/test_utils.py 99.21% <ø> (ø)
piptools/scripts/compile.py 100.00% <100.00%> (ø)
tests/test_cli_compile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54ad96...0b79f3a. Read the comment docs.

@atugushev
Copy link
Member

@jazzband/pip-tools

Hey, everyone! I'm on board to merge this PR and remove --index/--no-index in 6.0.0, it's been 9 months since the option was deprecated in 5.2.0. Let me know If anyone is opposed to this.

@atugushev atugushev added deprecation Related to deprecations or removals cli Related to command line interface things labels Mar 1, 2021
atugushev
atugushev approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@atugushev atugushev merged commit c10fd0e into jazzband:master Mar 3, 2021
This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Closed
This was referenced Mar 16, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
@UsamaSadiq UsamaSadiq mentioned this pull request Mar 26, 2021
Merged
@mzulqarnain1 mzulqarnain1 mentioned this pull request Jun 15, 2021
Merged
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 22, 2022
@bmwiedemann
Update python-pip-tools to version 6.5.1 / rev 2 via SR 962444
32829db 
https://build.opensuse.org/request/show/962444
by user mcepl + dimstar_suse
- version update to 6.5.1
  Backwards Incompatible Changes:
  - Remove support for EOL Python 3.5 and 2.7
    ([#1243](jazzband/pip-tools#1243)). Thanks @jdufresne
  - Remove deprecated `--index/--no-index` option from `pip-compile`
    ([#1234](jazzband/pip-tools#1234)). Thanks @jdufresne
  See CHANGELOG.md for more
@atugushev atugushev mentioned this pull request Nov 22, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
backwards incompatible Backwards incompatible change cli Related to command line interface things deprecation Related to deprecations or removals
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jdufresne @atugushev