Added LaTeX preview feature to all comment/feedback fields - #1017
Conversation
|
Thanks for the pull request, @bdero! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request. |
|
Thanks for the pull request, @bdero! I've created OSPR-1801 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information. |
56db8b6 to
fff4158
Compare
c21ce70 to
c979228
Compare
c979228 to
8fb5af0
Compare
|
We are testing here too (fun-mooc). Tests are conclusive so far: it works as advertised. |
|
@bdero - this looks great! Just want to confirm - the preview button only appears when a comment is written in latex? That is my only concern. |
|
@sstack22 Thanks, and yup, all of the preview buttons/areas will only show up if the latex option is enabled for the xblock. |
|
👍 from product review. |
efischer19
left a comment
There was a problem hiding this comment.
Looks great to me, thanks for the PR!
To include these changes: - openedx/edx-ora2#1016 - openedx/edx-ora2#1017 - openedx/edx-ora2#1022
Allow LaTeX previewing for multiple prompts Conflicts: openassessment/xblock/static/css/openassessment-ltr.css openassessment/xblock/static/css/openassessment-rtl.css openassessment/xblock/static/js/openassessment-lms.min.js
Development for openfun: ORA2 already offers LaTeX previewing when LaTeX is enabled for submissions, but the peer assessment and self assessment sections also allow for inputting LaTeX, even though there are no preview buttons for these fields.
This change adds a LaTeX preview button to each of these fields that are currently missing it.
Screenshot:
Testing setup:
/edx/app/srcdirectory, checkout the branch for this PR, and install the xblock like so:Advanced Settingsof a course in Studio and add"ora2"to the Advanced Module ListTrue, and click Save to close the settings dialogTesting instructions: