Skip to content

Fixed the "Allow LaTeX Responses" setting - #1016

Merged
gsong merged 1 commit into
masterfrom
bdero/latex-setting-fix
Jun 27, 2017
Merged

Fixed the "Allow LaTeX Responses" setting#1016
gsong merged 1 commit into
masterfrom
bdero/latex-setting-fix

Conversation

@bdero

@bdero bdero commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

Development for openfun: This is a small fix to make the LaTeX response setting work.

Testing instructions:

  1. Go to the Advanced Settings of a course in Studio and add "ora2" to the Advanced Module List
  2. Add an Open Response Assessment problem to a new Unit
  3. Select "Edit" on the new ORA problem to open the settings modal
  4. Change "Allow LaTeX Responses" to True, and click Save to close the settings dialog
  5. Select "Edit" again and observe that the "Allow LaTeX Responses" setting is incorrectly set back to False
  6. Clone this repository into the /edx/app/src directory, checkout the branch for this PR, and install the xblock like so:
    pip install -e file:///edx/src/edx-ora2/#egg=ora2==localdev
    
  7. Restart Studio and perform steps 3 and 4 again
  8. Select "Edit" to open the settings dialog again and observe that the value of "Allow LaTeX Responses" was correctly perserved as True

@bdero
bdero requested a review from e-kolpakov June 26, 2017 22:48
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bdero! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

Create an OSPR issue for this pull request.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bdero! I've created OSPR-1800 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jun 26, 2017
@gsong
gsong merged commit 93e0ca4 into master Jun 27, 2017
@bradenmacdonald

Copy link
Copy Markdown

That was fast - thanks @gsong !

@bradenmacdonald
bradenmacdonald deleted the bdero/latex-setting-fix branch June 28, 2017 00:03
@jul

jul commented Jun 30, 2017

Copy link
Copy Markdown

You are fast!
Looking this on monday.
Promise I will give an answer!

bdero added a commit to open-craft/openedx-platform that referenced this pull request Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants