feat: add PREPEND_LOCALE_PATHS configuration setting to Maple - #6757
Conversation
|
Thanks for the pull request, @keithgg! I've created OSPR-6688 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@natabene can someone take a look at this PR as well? My apologies for not pinging earlier. |
|
@keithgg Thanks for letting me know. I will line this up for our review. |
|
Hey, @keithgg Thanks for backporting the change in the maple. Can you please rebase your branch? |
edx-platform supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which appends paths to the end of LOCALE_PATHS, but there's currently no way to add additional paths to the start of the list. We want to be able to prepend locale paths so that we can override existing translations in edx-platform.
8789380 to
ca57c85
Compare
|
Hi @nadeemshahzad, thanks for reviewing. I've rebased. |
|
@keithgg 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
edx-platformcurrently supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which appends paths to the end of LOCALE_PATHS, but there's currently no way to add additional paths to the start of the list to override the default translations.In this PR, we added the
PREPEND_LOCALE_PATHSconfiguration setting to achieve this.Note: This is a cherry-picked commit from the PR: #6677
Configuration Pull Request
Make sure that the following steps are done before merging:
If you are updating a secure value rather than an internal one, file a SRE ticket with details.If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?