Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

feat: add PREPEND_LOCALE_PATHS configuration setting to Maple - #6757

Merged
nadeemshahzad merged 1 commit into
openedx-unsupported:open-release/maple.masterfrom
open-craft:keith/se_5299_maple_cherry_pick
Aug 1, 2022
Merged

feat: add PREPEND_LOCALE_PATHS configuration setting to Maple#6757
nadeemshahzad merged 1 commit into
openedx-unsupported:open-release/maple.masterfrom
open-craft:keith/se_5299_maple_cherry_pick

Conversation

@keithgg

@keithgg keithgg commented May 17, 2022

Copy link
Copy Markdown
Contributor

edx-platform currently supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which appends paths to the end of LOCALE_PATHS, but there's currently no way to add additional paths to the start of the list to override the default translations.

In this PR, we added the PREPEND_LOCALE_PATHS configuration setting to achieve this.

Note: This is a cherry-picked commit from the PR: #6677

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

@openedx-webhooks

openedx-webhooks commented May 17, 2022

Copy link
Copy Markdown

Thanks for the pull request, @keithgg! I've created OSPR-6688 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 17, 2022
@keithgg keithgg changed the title feat: add PREPEND_LOCALE_PATHS configuration setting feat: add PREPEND_LOCALE_PATHS configuration setting to Maple May 17, 2022

@pkulkark pkulkark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@keithgg

keithgg commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

@natabene can someone take a look at this PR as well? My apologies for not pinging earlier.

@natabene

Copy link
Copy Markdown
Contributor

@keithgg Thanks for letting me know. I will line this up for our review.

@nadeemshahzad

Copy link
Copy Markdown
Contributor

Hey, @keithgg Thanks for backporting the change in the maple. Can you please rebase your branch?

edx-platform supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which
appends paths to the end of LOCALE_PATHS,  but there's currently no
way to add additional paths to the start of the list.

We want to be able to prepend locale paths so that we can override
existing translations in edx-platform.
@keithgg
keithgg force-pushed the keith/se_5299_maple_cherry_pick branch from 8789380 to ca57c85 Compare August 1, 2022 11:11
@keithgg

keithgg commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

Hi @nadeemshahzad, thanks for reviewing. I've rebased.

@nadeemshahzad
nadeemshahzad merged commit daf3145 into openedx-unsupported:open-release/maple.master Aug 1, 2022
@openedx-webhooks

Copy link
Copy Markdown

@keithgg 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants