This repository was archived by the owner on May 6, 2024. It is now read-only.
feat: add PREPEND_LOCALE_PATHS configuration setting - #6677
Merged
nadeemshahzad merged 1 commit intoFeb 7, 2022
Merged
Conversation
edx-platform supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which appends paths to the end of LOCALE_PATHS, but there's currently no way to add additional paths to the start of the list. We want to be able to prepend locale paths so that we can override existing translations in edx-platform.
|
Thanks for the pull request, @keithgg! I've created OSPR-6426 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
needs triage
open-source-contribution
Contributor
|
@keithgg Thank you for your contribution, I will line this up for our review. |
nadeemshahzad
approved these changes
Feb 7, 2022
|
@keithgg 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
7 tasks
0x29a
pushed a commit
to open-craft/configuration
that referenced
this pull request
May 4, 2022
…5299_prepend_local_paths feat: add PREPEND_LOCALE_PATHS configuration setting (cherry picked from commit e397261)
This was referenced May 17, 2022
0x29a
pushed a commit
to open-craft/configuration
that referenced
this pull request
May 28, 2022
…5299_prepend_local_paths feat: add PREPEND_LOCALE_PATHS configuration setting (cherry picked from commit e397261)
0x29a
pushed a commit
to open-craft/configuration
that referenced
this pull request
May 30, 2022
…5299_prepend_local_paths feat: add PREPEND_LOCALE_PATHS configuration setting (cherry picked from commit e397261)
github-actions Bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Jul 3, 2022
…o Maple #Description Backports the changes made in #29851 to `maple.master`. > edx-platform currently supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which appends paths to the end of LOCALE_PATHS, but there's currently no way to add additional paths to the start of the list to override the default translations. > > In this PR, we added the PREPEND_LOCALE_PATHS setting to achieve this. > > - Affects the Operator ## Supporting information - PR for the `configuration` repo. openedx-unsupported/configuration#6677 - [SE-5299](https://tasks.opencraft.com/browse/SE-5299) ## Testing instructions On the docker devstack: - `make dev.shell.lms` - Edit the file `/edx/etc/lms.yml`. Add a `PREPEND_LOCALE_PATHS` setting like ```yaml PREPEND_LOCALE_PATHS: [/edx/src/] ``` - Copy a translation file into that folder. ```bash cp -r /edx/app/edxapp/edx-platform/conf/locale/fr/ /edx/src/es ``` Note that this is copying French to Spanish folder. It makes seeing the differences easier. - In your browser load the LMS, and change the `openedx-language-cookie`'s value to `es`. - Restart your lms dev server. - If done correctly you should get the french translations loaded (it sometimes takes 5 minutes to load).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edx-platformcurrently supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which appends paths to the end of LOCALE_PATHS, but there's currently no way to add additional paths to the start of the list to override the default translations.In this PR, we added the
PREPEND_LOCALE_PATHSconfiguration setting to achieve this.Configuration Pull Request
Make sure that the following steps are done before merging:
If you are updating a secure value rather than an internal one, file a SRE ticket with details.If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?