feat: add nginx server names hash override [BB-5512] - #6682
Conversation
|
Thanks for the pull request, @kaustavb12! I've created OSPR-6454 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
- ✅ I tested this, checked deployed changes on OCIM.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ✅ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
|
@kaustavb12 Thank you for your contribution. Please let me know once it is ready for our review. |
|
@natabene This PR is ready for your review |
|
@kaustavb12 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Configuration Pull Request --- ## Description cherry picked from commit [`59cbc50`](59cbc50) ([PR#6682](#6682)) This PR adds support for optional configuration of `nginx server_names_hash_bucket_size` in case length of the hostname exceeds the default hash bucket size. ## Supporting information [BB-5512](https://tasks.opencraft.com/browse/BB-5512) Make sure that the following steps are done before merging: - [ ] A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services. - [ ] Are you adding any new default values that need to be overridden when this change goes live? If so: - [ ] Update the appropriate internal repo (be sure to update for all our environments) - [ ] If you are updating a secure value rather than an internal one, file a SRE ticket with details. - [ ] Add an entry to the CHANGELOG. - [ ] If you are making a complicated change, have you performed the proper testing specified on the [Ops Ansible Testing Checklist](https://openedx.atlassian.net/wiki/spaces/SRE/pages/28967861/Ops+Ansible+Testing+Checklist)? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes). - [ ] Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?
Configuration Pull Request --- ## Description cherry picked from commit [`59cbc50`](59cbc50) ([PR#6682](#6682)) This PR adds support for optional configuration of `nginx server_names_hash_bucket_size` in case length of the hostname exceeds the default hash bucket size. ## Supporting information [BB-5512](https://tasks.opencraft.com/browse/BB-5512) Make sure that the following steps are done before merging: - [ ] A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services. - [ ] Are you adding any new default values that need to be overridden when this change goes live? If so: - [ ] Update the appropriate internal repo (be sure to update for all our environments) - [ ] If you are updating a secure value rather than an internal one, file a SRE ticket with details. - [ ] Add an entry to the CHANGELOG. - [ ] If you are making a complicated change, have you performed the proper testing specified on the [Ops Ansible Testing Checklist](https://openedx.atlassian.net/wiki/spaces/SRE/pages/28967861/Ops+Ansible+Testing+Checklist)? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes). - [ ] Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?
Configuration Pull Request
Description
This PR adds support for optional configuration of nginx server_names_hash_bucket_size in case length of the hostname exceeds the default hash bucket size.
Supporting information
BB-5512
TODO
Cherry-pick to
open-release/lilac.masterandopen-release/maple.masteronce this is merged.Make sure that the following steps are done before merging: