feat: add nginx server names hash override [BB-5512] - #6686
Conversation
|
Thanks for the pull request, @kaustavb12! I've created OSPR-6479 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
- ✅ I tested this, we have deployed this on various platforms
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ✅ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
|
@kaustavb12 Thank you for your contribution. Is this ready for our review? |
|
@natabene Yes it is :) |
|
@BbrSofiane Could you please have this reviewed and merged? This is a cherry pick for Maple. |
|
@edx-community-bot merge |
|
@openedx-community-bot merge |
5bd1156
into
openedx-unsupported:open-release/maple.master
|
@kaustavb12 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Configuration Pull Request
Description
cherry picked from commit
59cbc50(PR#6682)This PR adds support for optional configuration of
nginx server_names_hash_bucket_sizein case length of the hostname exceeds the default hash bucket size.Supporting information
BB-5512
Make sure that the following steps are done before merging: