Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

lilac backport: add Elasticsearch variable overrides - #6659

Merged
pomegranited merged 2 commits into
openedx-unsupported:open-release/lilac.masterfrom
open-craft:agrendalath/cherry-pick_#6646_lilac
Jan 16, 2022
Merged

lilac backport: add Elasticsearch variable overrides#6659
pomegranited merged 2 commits into
openedx-unsupported:open-release/lilac.masterfrom
open-craft:agrendalath/cherry-pick_#6646_lilac

Conversation

@Agrendalath

@Agrendalath Agrendalath commented Jan 13, 2022

Copy link
Copy Markdown
Contributor

This backports #6646 to Lilac.

Agrendalath and others added 2 commits January 13, 2022 17:55
@Agrendalath @0x29a
fix: replace ELASTICSEARCH_URL with ELASTICSEARCH_CLUSTER_URL for…
7bf713a 
… discovery

The variable name has been changed in:
edx/course-discovery@df5e75f

Co-authored-by: @0x29a <demid@opencraft.com>
@Agrendalath @0x29a
fix: replace ELASTICSEARCH_URL with ELASTICSEARCH_DSL for edx_not…
dae3648 
…es_api

The variable name has been changed in:
edx/edx-notes-api@e24a267

Co-authored-by: @0x29a <demid@opencraft.com>
@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jan 13, 2022
@openedx-webhooks

openedx-webhooks commented Jan 13, 2022

Copy link
Copy Markdown

Thanks for the pull request, @Agrendalath! I've created OSPR-6385 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Agrendalath Agrendalath mentioned this pull request Jan 13, 2022
Merged
3 tasks
@natabene

natabene commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

@Agrendalath Thank you for your contribution. @pomegranited Would you be able to review and merge this one as well?

pomegranited
pomegranited approved these changes Jan 16, 2022
View reviewed changes

@pomegranited pomegranited left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this by checking the updated variable names against lilac.master's course_discovery.settings.production and notesserver.settings.common.
  • I checked the code against the original PR#
  • I made sure any change in configuration variables is reflected in the corresponding
    client's configuration-secure repository.     N/A

@pomegranited
pomegranited merged commit a5d94bf into openedx-unsupported:open-release/lilac.master Jan 16, 2022
@pomegranited
pomegranited deleted the agrendalath/cherry-pick_#6646_lilac branch January 16, 2022 23:11
@openedx-webhooks

openedx-webhooks commented Jan 16, 2022

Copy link
Copy Markdown

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pomegranited pomegranited pomegranited approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Agrendalath @openedx-webhooks @natabene @pomegranited