fix: add Elasticsearch variable overrides

[Agrendalath]

Elasticsearch variables have been renamed for discovery and edx_notes_api services after the Koa release. This replaces the old names with the new ones.

Reviewers

• @kaustavb12
• CC / edX reviewer[s] TBD

Follow-up

• Cherry-pick to open-release/lilac.master and open-release/maple.master once we merge this.

[openedx-webhooks]

Thanks for the pull request, @Agrendalath! I've created OSPR-6356 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[kaustavb12]

👍

• I tested this: I have verified that the corresponding variables have been changed in the course-discovery and edx-notes-api repos for lilac
• I read through the code
• Includes documentation

[Agrendalath]

@nizarmah, would you be able to add this to the OSPR list?

It could be a good candidate for the CC review.

[natabene]

@Agrendalath Thank you for your contribution. @pomegranited Are you interested in reviewing this?

[pomegranited]

@natabene Yep! I'll review this next sprint (starts Tues 11 Jan).

[nizarmah]

Yes @Agrendalath! I was going to ask @pomegranited as well, thank you so much @natabene!

[pomegranited]

👍

• I tested this by deploying an Ocim appserver using this branch, with Notes and Discovery services enabled. I checked that the configured ES hostnames made it through to the Notes and Discovery .yml files.
• I read through the code, and checked the updated variable names against course_discovery.settings.production and notesserver.settings.common.
• Includes documentation
• Commit structure follows OEP-0051
• I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository. N/A

[nadeemshahzad]

@Agrendalath Looks good to me.

[Agrendalath]

Thanks for reviewing this, @pomegranited and @nadeemshahzad. Given that this is already approved, and won't likely need any changes, I've opened #6659 and #6660 to backport it to Lilac and Maple. Would you mind reviewing these too (and merging them, if possible)?

[natabene]

So who can merge this?

[Agrendalath]

@natabene, @pomegranited is going to merge this one on Monday.

[openedx-webhooks]

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.