feat: Add model-util CLI #59
Conversation
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Co-authored-by: Prashant Gupta <prashantgupta@us.ibm.com>
|
Please see the contributing guide for information on how to set up |
|
vllm@main CI will keep failing until #68 solves the problem and is merged |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 62.08% 54.70% -7.38%
==========================================
Files 21 24 +3
Lines 1216 1444 +228
Branches 213 259 +46
==========================================
+ Hits 755 790 +35
- Misses 386 579 +193
Partials 75 75 ☔ View full report in Codecov by Sentry. |
|
@rafvasq can you trim down the commits? |
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.5.4 to 0.5.5. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.5.4...0.5.5) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
|
Trimmed them down, @prashantgupta24 |
|
Thanks @rafvasq, and thanks @prashantgupta24 @dtrifiro for all of the reviews. This is looking great! I know there was already some discussion about this above but I'm wondering whether we should make the command something different. Maybe even just make it Or even something like |
I was a bit hesitant in using |
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Imho it shouldn't introduce confusion, just would hopefully allow their existing scripts/processes to work without change. But if it's not straightforward to make an alias then I guess not a huge deal. |
|
@njhill, sorry I forgot to mention it but I did introduce the |
|
Thanks @rafvasq. This looks very good at this point, just a few nits left |
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Supersedes ✨ add tgis-cli tools IBM/vllm#16, feat: add CLI tools IBM/vllm#52, feat: add TGIS CLI commands vllm#92
Related to: [Feature] vLLM CLI for serving and querying OpenAI compatible server vllm-project/vllm#5090
Changes:
model-utilortext-generation-servermodel-util download-weightsmodel-util convert-to-safetensorsmodel-util convert-to-fast-tokenizer