Closed
Conversation
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Co-authored-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Closed
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Member
|
Closing in favor of opendatahub-io/vllm#92 |
tdoublep
pushed a commit
that referenced
this pull request
Jan 20, 2025
This PR cleans and simplifies the code. ### Changes: - removed right padding since not used - removed dict of `seq_ids` since on `AIU` only **one** `seq_id` **per** `request_id` (no beam search or other multi sequence decoding) - removed for loop over single `seq_id` (always 1 per `request_id`) during decoding - deleting batch padding mask and position ids after decode has finished instead of overwriting it. - merged main into this branch to resolve merge conflicts The code has been in client/server mode for the `llama 194m` and `granite 3b` on `AIU` and `CPU`.
tdoublep
pushed a commit
that referenced
this pull request
Jan 20, 2025
This PR cleans and simplifies the code. ### Changes: - simplified warmup by using a function call to remove duplicated lines - moving mask and position_ids from `SENDNNCasualLM` to `SENDNNModelRunner` - fixing error in pyproject.toml - already merged PR #52 and main into this branch for easier merge. The code has been in client/server mode for the `llama 194m` and `granite 3b` on `AIU` and `CPU`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vllm serveto wrapvllm.entrypoints.openai.api_servervllm-project/vllm#4167