Skip to content

fix(feature): use correct error variable name - #882

Merged
VaishnaviHire merged 1 commit into
opendatahub-io:incubationfrom
iNecas:err-var-fix
Feb 26, 2024
Merged

fix(feature): use correct error variable name#882
VaishnaviHire merged 1 commit into
opendatahub-io:incubationfrom
iNecas:err-var-fix

Conversation

@iNecas

@iNecas iNecas commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

Description

Small fix for error noticed when playing around.

How Has This Been Tested?

Due to size of the change, just checked the code compiles and runs.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci

openshift-ci Bot commented Feb 26, 2024

Copy link
Copy Markdown

Hi @iNecas. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@VaishnaviHire

VaishnaviHire commented Feb 26, 2024

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Ok to Test and removed needs-ok-to-test labels Feb 26, 2024
VaishnaviHire
VaishnaviHire approved these changes Feb 26, 2024
View reviewed changes

@VaishnaviHire VaishnaviHire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Feb 26, 2024
@openshift-ci

openshift-ci Bot commented Feb 26, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaishnaviHire
VaishnaviHire merged commit 0d8bd14 into opendatahub-io:incubation Feb 26, 2024
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Feb 27, 2024
@iNecas @VaishnaviHire
fix(feature): use correct error variable name (opendatahub-io#882)
ab24640 
(cherry picked from commit 0d8bd14)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Feb 27, 2024
@iNecas @VaishnaviHire
fix(feature): use correct error variable name (opendatahub-io#882)
20dfb76 
(cherry picked from commit 0d8bd14)
zdtsw referenced this pull request in red-hat-data-services/rhods-operator Mar 1, 2024
@VaishnaviHire @zdtsw
@iNecas @VedantMahabaleshwarkar
Sync kserve raw deployments (#202)
ddba9a8 
* Update Owners and Owwners-aliases (#869)

(cherry picked from commit 7f477a3)

* fix(DSC): do not reconcile resource if it has a special annotation (#879)

* fix(DSC+Kserve): do not reconcile inferenceservice-config for
rawdeployment

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* fix: wrong logic

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* feat(deploy): do not set ownerreference if resource has sepcial
annotation to false

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* update: change logic to --if kind is CRD do not care annotation

* update: change logic

- we still set ownerreference on resources
- we only skip reconcile if resource has defined annotation

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* fix(typo)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* Update: limite scope of annoation to only kserve resource for now

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 20f4ad0)

* fix(feature): use correct error variable name (#882)

(cherry picked from commit 0d8bd14)

* allow setting default deployment mode for Kserve in DSC (#864)

* allow setting default deployment mode for Kserve in DSC

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* move kserve config logic to separate file + enhancements

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* revert dev image set in operator CSV

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* only setup kserve config if component is enabled

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* bug fix

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* address PR feedback

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* cleanup

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* fix lint error

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* set default value for Kserve defaultDeploymentMode to be empty

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* more pr feedback

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* update bundle

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* enhance documentation

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* add readme for dev preview

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

---------

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
(cherry picked from commit cebd287)

* Update bundle

---------

Co-authored-by: Wen Zhou <wenzhou@redhat.com>
Co-authored-by: Ivan Necas <necasik@gmail.com>
Co-authored-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
ykaliuta pushed a commit to ykaliuta/opendatahub-operator that referenced this pull request Mar 5, 2024
@iNecas Yauheni Kaliuta
fix(feature): use correct error variable name (opendatahub-io#882)
24cfcf4
github-actions Bot pushed a commit to ykaliuta/opendatahub-operator that referenced this pull request Mar 6, 2024
@iNecas @ykaliuta
fix(feature): use correct error variable name (opendatahub-io#882)
0e2cd56 
(cherry picked from commit 24cfcf4)
github-actions Bot pushed a commit to ykaliuta/opendatahub-operator that referenced this pull request Mar 6, 2024
@iNecas @ykaliuta
fix(feature): use correct error variable name (opendatahub-io#882)
ab1fcd0 
(cherry picked from commit 24cfcf4)
github-actions Bot pushed a commit to ykaliuta/opendatahub-operator that referenced this pull request Mar 6, 2024
@iNecas @ykaliuta
fix(feature): use correct error variable name (opendatahub-io#882)
93d526d 
(cherry picked from commit 24cfcf4)
ykaliuta pushed a commit to ykaliuta/opendatahub-operator that referenced this pull request Mar 6, 2024
@iNecas Yauheni Kaliuta
fix(feature): use correct error variable name (opendatahub-io#882)
7fedddc
github-actions Bot pushed a commit to ykaliuta/opendatahub-operator that referenced this pull request Mar 6, 2024
@iNecas @ykaliuta
fix(feature): use correct error variable name (opendatahub-io#882)
cbc4871 
(cherry picked from commit 7fedddc)
robotmaxtron pushed a commit to robotmaxtron/opendatahub-operator that referenced this pull request Sep 17, 2025
@VaishnaviHire @zdtsw
@iNecas @VedantMahabaleshwarkar @robotmaxtron
Sync kserve raw deployments (opendatahub-io#202)
24cd8ce 
* Update Owners and Owwners-aliases (opendatahub-io#869)

(cherry picked from commit 7f477a3)

* fix(DSC): do not reconcile resource if it has a special annotation (opendatahub-io#879)

* fix(DSC+Kserve): do not reconcile inferenceservice-config for
rawdeployment

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* fix: wrong logic

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* feat(deploy): do not set ownerreference if resource has sepcial
annotation to false

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* update: change logic to --if kind is CRD do not care annotation

* update: change logic

- we still set ownerreference on resources
- we only skip reconcile if resource has defined annotation

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* fix(typo)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* Update: limite scope of annoation to only kserve resource for now

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 20f4ad0)

* fix(feature): use correct error variable name (opendatahub-io#882)

(cherry picked from commit 0d8bd14)

* allow setting default deployment mode for Kserve in DSC (opendatahub-io#864)

* allow setting default deployment mode for Kserve in DSC

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* move kserve config logic to separate file + enhancements

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* revert dev image set in operator CSV

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* only setup kserve config if component is enabled

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* bug fix

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* address PR feedback

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* cleanup

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* fix lint error

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* set default value for Kserve defaultDeploymentMode to be empty

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* more pr feedback

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* update bundle

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* enhance documentation

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

* add readme for dev preview

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

---------

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
(cherry picked from commit cebd287)

* Update bundle

---------

Co-authored-by: Wen Zhou <wenzhou@redhat.com>
Co-authored-by: Ivan Necas <necasik@gmail.com>
Co-authored-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Signed-off-by: Max Whittingham <mwhittingham@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etirelli etirelli Awaiting requested review from etirelli
1 more reviewer
@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@VaishnaviHire VaishnaviHire

Labels

approved lgtm ok-to-test Ok to Test

Projects

ODH Platform Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iNecas @VaishnaviHire