[VaishnaviHire]

Description

To expedite PR reviews and testing, added appropriate component owners to the repo.

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[bartoszmajsak]

@VaishnaviHire how would it work now? Would it automatically add all people from platform alias for every PR review? That would be a huge load on your side.

On a semi-related note - what is the process for reviewing PRs? Specifically where I'm looking for clarification is:

• how many lgtms does a PR need (how many reviewers) to be considered mergeable?
• who is responsible for merging the PR? clearly bot is not active (but maybe this will change it). should it be the author?
• can I change automatically assigned reviewers to those e.g. suggested by GH (who most recently touched given code) or me wanting to share this knowledge with people I think are most affected or have the most expertise in the area

And a side quest to consider:

• I am using conventional commits prefixes (or some subset of it), but there's no rule about it. Wondering if we want to leave it open or ask to have PR titles at least following this in this repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zdtsw
Once this PR has been reviewed and has the lgtm label, please ask for approval from vaishnavihire. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VaishnaviHire]

@VaishnaviHire how would it work now? Would it automatically add all people from platform alias for every PR review? That would be a huge load on your side.

On a semi-related note - what is the process for reviewing PRs? Specifically where I'm looking for clarification is:

• how many lgtms does a PR need (how many reviewers) to be considered mergeable?
• who is responsible for merging the PR? clearly bot is not active (but maybe this will change it). should it be the author?
• can I change automatically assigned reviewers to those e.g. suggested by GH (who most recently touched given code) or me wanting to share this knowledge with people I think are most affected or have the most expertise in the area

Hi! I don't think it adds all the people. Following the guidelines here, the OWNERS_ALIASES file should now be parsed by tide. The goal was to atleast document list of reviewers for every component.

As follow up of this we will also fix the merge bot. I think 1 lgtm and 1 approval should be okay(let me know if you think otherwise). We need to remove the cherry-pick-approved label check to unblock automatic merges.

And a side quest to consider:

• I am using conventional commits prefixes (or some subset of it), but there's no rule about it. Wondering if we want to leave it open or ask to have PR titles at least following this in this repository.

Maybe referencing this in Contributing guidelines will be helpful.

[anishasthana]

@dhirajsb should we have at least one more owner?

[VaishnaviHire]

@dhirajsb Can you recommend anyone from model registry that we can add as reviewers?

[dhirajsb]

@tarilabs and @rareddy can be added as model-registry reviewers.

[anishasthana]

Nit: Quite a few of the rows are not sorted in alphabetical order.

[harshad16]

/lgtm
from my end.