Skip to content

[sync]: fix: add missing namespace for console in managed cluster (#1552) - #1556

Merged
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:rhoaifrom
zdtsw-forking:sync_pr_1552
Jan 23, 2025
Merged

openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:rhoaifrom
zdtsw-forking:sync_pr_1552

Conversation

@zdtsw

@zdtsw zdtsw commented Jan 23, 2025

Copy link
Copy Markdown
Member
  • blackbox require this
  • move into const in cluster pkg

Signed-off-by: Wen Zhou wenzhou@redhat.com
(cherry picked from commit 28d0fa1)

Description

RHOAIENG-14787

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…b-io#1552)

- blackbox require this
- move into const in cluster pkg

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 28d0fa1)
@zdtsw zdtsw added the rhoai label Jan 23, 2025
@openshift-ci
openshift-ci Bot requested review from asanzgom and ugiordan January 23, 2025 10:54
@openshift-ci

openshift-ci Bot commented Jan 23, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ugiordan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jan 23, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.26%. Comparing base (6e2808c) to head (7c9f51b).
Report is 1 commits behind head on rhoai.

Files with missing lines Patch % Lines
controllers/dscinitialization/monitoring.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            rhoai    #1556   +/-   ##
=======================================
  Coverage   20.26%   20.26%           
=======================================
  Files         161      161           
  Lines       10977    10977           
=======================================
  Hits         2225     2225           
  Misses       8513     8513           
  Partials      239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 33c2112 into opendatahub-io:rhoai Jan 23, 2025
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Jan 28, 2025
…flux/component-updates/odh-kuberay-operator-controller-v2-17

chore(deps): update odh-kuberay-operator-controller-v2-17 to 8a80976
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Jan 28, 2025
* fix: add missing namespace for console in managed cluster (opendatahub-io#1552) (opendatahub-io#1556)

- blackbox require this
- move into const in cluster pkg

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 28d0fa1)
(cherry picked from commit 33c2112)

* fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) (opendatahub-io#1560)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 63d4eab)
(cherry picked from commit 2b0a5d2)

* update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) (opendatahub-io#1561)

- remove subs from client cache
- add smcp into exclude cache

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit bc63cfd)
(cherry picked from commit bd9fdc4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants