Skip to content

(feat): Add roles and cluster roles for admingroups #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Jan 16, 2025
Merged

(feat): Add roles and cluster roles for admingroups #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5af8436
(feat): Add roles and cluster roles for admingroups
AjayJagan Jan 15, 2025
14091f0
add "RU" for dsc resource
AjayJagan Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions controllers/services/auth/resources/admingroup-clusterrole.tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,43 @@ rules:
- auths/status
verbs:
- get
- apiGroups:
- modelregistry.opendatahub.io
resources:
- modelregistires

@sanandpa sanandpa Jan 17, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in 'modelregistires'

@AjayJagan AjayJagan Jan 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, my bad. Thanks for pointing it out @sanandpa . Will create a fix now

@AjayJagan AjayJagan Jan 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed here: #1512

verbs:
- watch
- update
- get
- list
- create
- patch
- delete
- apiGroups:
- storage.k8s.io
resources:
- storageclasses
verbs:
- update
- patch
- apiGroups:
- user.openshift.io
resources:
- groups
- users
verbs:
- get
- list
- watch
- apiGroups:
- nim.opendatahub.io
resources:
- accounts
verbs:
- watch
- update
- get
- list
- create
- patch
- delete
102 changes: 102 additions & 0 deletions controllers/services/auth/resources/admingroup-role.tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,105 @@ rules:
- auths/status
verbs:
- get
- apiGroups:
- dashboard.opendatahub.io
resources:
- acceleratorprofiles
verbs:
- create
- get
- list
- patch
- delete
- apiGroups:
- route.openshift.io
resources:
- routes
verbs:
- get
- list
- watch
- apiGroups:
- batch
resources:
- cronjobs
verbs:
- get
- update
- watch
- apiGroups:
- image.openshift.io
resources:
- imagestreams
verbs:
- create
- get
- list
- patch
- delete
- watch
- apiGroups:
- build.openshift.io
resources:
- builds
- buildconfigs
verbs:
- list
- apiGroups:
- apps
resources:
- deployments
verbs:
- patch
- update
- apiGroups:

@StevenTobin StevenTobin Jan 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also a requirement for the admin to be able to RU the DSC.

- opendatahub.io
resources:
- odhdashboardconfigs
verbs:
- get
- watch
- create
- update
- patch
- apiGroups:
- datasciencecluster.opendatahub.io
resources:
- datascienceclusters
verbs:
- get
- list
- watch
- update
- apiGroups:
- dashboard.opendatahub.io
resources:
- odhapplications
- odhdocuments
verbs:
- get
- list
- apiGroups:
- console.openshift.io
resources:
- odhquickstarts
verbs:
- get
- list
- apiGroups:
- template.openshift.io
resources:
- templates
verbs:
- get
- list
- watch
- create
- patch
- delete
- apiGroups:
- serving.kserve.io
resources:
- servingruntimes
verbs:
- create