Repository navigation
(feat): Add roles and cluster roles for admingroups - #1508
Conversation
| verbs: | ||
| - patch | ||
| - update | ||
| - apiGroups: |
There was a problem hiding this comment.
There was also a requirement for the admin to be able to RU the DSC.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
=======================================
Coverage 19.78% 19.78%
=======================================
Files 160 160
Lines 10880 10880
=======================================
Hits 2153 2153
Misses 8500 8500
Partials 227 227 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: StevenTobin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
| - apiGroups: | ||
| - modelregistry.opendatahub.io | ||
| resources: | ||
| - modelregistires |
There was a problem hiding this comment.
oops, my bad. Thanks for pointing it out @sanandpa . Will create a fix now
…flux/component-updates/odh-model-registry-v2-17 chore(deps): update odh-model-registry-v2-17 to 3c5518b
|
/cherrypick rhoai |
|
@lburgazzoli: new pull request created: #1893 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Add clusterroles/roles for admin users.
Note: this is a part of the admin permissions work.
JIRA: https://issues.redhat.com/browse/RHOAIENG-14235