Skip to content

(feat): Add roles and cluster roles for admingroups - #1508

Merged
openshift-merge-bot[bot] merged 2 commits into
opendatahub-io:mainfrom
AjayJagan:add-roles-auth
Jan 16, 2025
Merged

openshift-merge-bot[bot] merged 2 commits into
opendatahub-io:mainfrom
AjayJagan:add-roles-auth

Conversation

@AjayJagan

Copy link
Copy Markdown
Member

Description

Add clusterroles/roles for admin users.

Note: this is a part of the admin permissions work.

JIRA: https://issues.redhat.com/browse/RHOAIENG-14235

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@AjayJagan

Copy link
Copy Markdown
Member Author

/cc @StevenTobin @andrewballantyne

verbs:
- patch
- update
- apiGroups:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also a requirement for the admin to be able to RU the DSC.

@codecov

codecov Bot commented Jan 16, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.78%. Comparing base (68c6cae) to head (14091f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   19.78%   19.78%           
=======================================
  Files         160      160           
  Lines       10880    10880           
=======================================
  Hits         2153     2153           
  Misses       8500     8500           
  Partials      227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StevenTobin

Copy link
Copy Markdown
Contributor

/lgtm

@StevenTobin

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jan 16, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: StevenTobin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the lgtm label Jan 16, 2025
@StevenTobin

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jan 16, 2025
@openshift-merge-bot
openshift-merge-bot Bot merged commit e80a9b5 into opendatahub-io:main Jan 16, 2025
- apiGroups:
- modelregistry.opendatahub.io
resources:
- modelregistires

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in 'modelregistires'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, my bad. Thanks for pointing it out @sanandpa . Will create a fix now

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed here: #1512

MarianMacik pushed a commit to MarianMacik/opendatahub-operator that referenced this pull request Jan 22, 2025
…flux/component-updates/odh-model-registry-v2-17

chore(deps): update odh-model-registry-v2-17 to 3c5518b
@lburgazzoli

Copy link
Copy Markdown
Member

/cherrypick rhoai

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lburgazzoli: new pull request created: #1893

Details

In response to this:

/cherrypick rhoai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants