Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curvefs/metaserver: s3compat support "truncate smaller" correctly #1306

Merged
merged 1 commit into from
Apr 25, 2022
Merged

curvefs/metaserver: s3compat support "truncate smaller" correctly #1306

merged 1 commit into from
Apr 25, 2022

Conversation

h0hmj
Copy link
Contributor

@h0hmj h0hmj commented Apr 20, 2022

s3compact now will process two kinds of chunk

  1. the whole chunk is useless; chunkSize * chunkIndex > inodeLen-1
  2. part of the chunk is useless; some info in list off+len-1 > inodeLen -1

i wll delete these useless data

@h0hmj
Copy link
Contributor Author

h0hmj commented Apr 20, 2022

solve #1049
affected by #1304 which will make input of s3compact is wrong
affected by #1308 which will make metadata deletion from s3compact be dropped

@h0hmj h0hmj requested review from Wine93 and wu-hanqing April 21, 2022 02:07
Wine93
Wine93 approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@Wine93 Wine93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@h0hmj h0hmj merged commit 1112742 into opencurve:master Apr 25, 2022
@h0hmj h0hmj deleted the s3compact-support-truncate-smaller branch May 30, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wine93 Wine93 Wine93 approved these changes

@wu-hanqing wu-hanqing wu-hanqing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h0hmj @Wine93 @wu-hanqing