Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curvefs/metaserver: s3ChunkInfoRemove in GetOrModifyS3ChunkInfoRequest is not used. #1308

Closed
h0hmj opened this issue Apr 20, 2022 · 0 comments
Closed

curvefs/metaserver: s3ChunkInfoRemove in GetOrModifyS3ChunkInfoRequest is not used. #1308

h0hmj opened this issue Apr 20, 2022 · 0 comments
Assignees
@Wine93
Labels
bug Something isn't working high high priority need test Completion of development, requires QA verification

Comments

@h0hmj
Copy link
Contributor

h0hmj commented Apr 20, 2022

Describe the bug (描述bug)

s3ChunkInfoRemove in GetOrModifyS3ChunkInfoRequest is not used.

the logic of update may be wrong, when add is empty, but delete is not empty (just delete chunks from truncate smaller)

To Reproduce (复现方法)

Expected behavior (期望行为)

Versions (各种版本)
commit: c783e83

Additional context/screenshots (更多上下文/截图)
@h0hmj h0hmj added the bug Something isn't working label Apr 20, 2022
@h0hmj h0hmj mentioned this issue Apr 20, 2022
Merged
@Wine93 Wine93 mentioned this issue May 7, 2022
Merged
@wuhongsong wuhongsong added the high high priority label May 9, 2022
Wine93 added a commit that referenced this issue May 14, 2022
@Wine93
curvefs/metaserver: recover s3ChunkInfoRemove field for GetOrModifyS3…
e3aef89 
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (#1304) (#1308)
@Wine93 Wine93 added the need test Completion of development, requires QA verification label May 14, 2022
fansehep pushed a commit to fansehep/curve that referenced this issue May 25, 2022
@Wine93 @fansehep
curvefs/metaserver: recover s3ChunkInfoRemove field for GetOrModifyS3…
e5f6aa7 
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (opencurve#1304) (opencurve#1308)
fansehep pushed a commit to fansehep/curve that referenced this issue May 25, 2022
@Wine93 @fansehep
curvefs/metaserver: recover s3ChunkInfoRemove field for GetOrModifyS3…
ba9fa81 
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (opencurve#1304) (opencurve#1308)
fansehep pushed a commit to fansehep/curve that referenced this issue May 28, 2022
@Wine93 @fansehep
curvefs/metaserver: recover s3ChunkInfoRemove field for GetOrModifyS3…
d86e122 
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (opencurve#1304) (opencurve#1308)
YunhuiChen pushed a commit that referenced this issue May 30, 2022
@Wine93 @YunhuiChen
curvefs/metaserver: recover s3ChunkInfoRemove field for GetOrModifyS3…
07a9e76 
…ChunkInfo PRC request

and guarantee consistent of s3chunkinfo in inode. (#1304) (#1308)
@Wine93 Wine93 closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wine93 Wine93

Labels
bug Something isn't working high high priority need test Completion of development, requires QA verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wine93 @h0hmj @wuhongsong