validate: Move syscalls into validate_posix #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
validate-syscalls
branch
from
d7bc416 to
c73e5ea
Compare
So the rest of the validation will compile on Windows. There might be a way to do these FileInfo comparisons on Windows, but I haven't had the time to figure that out yet. Signed-off-by: W. Trevor King <[email protected]>
|
With #560 merged, I'm not sure what the plan is for cross-platform, host-agnostic validation. Is that no longer a goal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the rest of the validation will compile on Windows. There might be a way to do these
FileInfocomparisons on Windows, but I haven't had the time to figure that out yet.This is a narrower alternative to #560 which still allows a Windows host to perform the bulk of the host-agnostic validation for a Linux config.