Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate: CheckLinux is platform dependent #560

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Jan 24, 2018

Signed-off-by: Vincent Batts [email protected]

@liangchenye
Copy link
Member

Hi @vbatts , I think 'validate.go' built in a non-Linux environment could also validate the Linux struct.

@wking
Copy link
Contributor

wking commented Jan 24, 2018 via email

@liangchenye
Copy link
Member

liangchenye commented Jan 26, 2018

LGTM
I just reviewed #561. I feel it will be clearer and easier to maintain if we move all the Linux checking/generating works out.

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Jan 26, 2018

I feel it will be clearer and easier to maintain if we move all the Linux checking/generating works out.

But you lose the ability to do host-agnostic, cross-platform validation. More on that in #445. Is cross-platform validation not a goal of this project?

@wking
Copy link
Contributor

wking commented Jan 26, 2018

I've filed #565 with a start at the narrower change I think we want to see, allowing for Windows hosts to compile validate (like this PR) but retaining the ability of Windows hosts to perform most host-agnostic validation of the linux config (unlike this PR).

@zhouhao3
Copy link

zhouhao3 commented Mar 3, 2018

Need rebase @vbatts .

@vbatts
Copy link
Member Author

vbatts commented Mar 5, 2018

updated. PTAL.

@zhouhao3
Copy link

zhouhao3 commented Mar 6, 2018

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit 34d0d59 into opencontainers:master Mar 6, 2018
@vbatts vbatts deleted the platform branch March 6, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants