Skip to content

logs.go fixed logger creation #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

logs.go fixed logger creation #4250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libcontainer/logs/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ func ForwardLogs(logPipe io.ReadCloser) chan error {
}

go func() {
defer close(done) // defer close(done) to ensure done is always closed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is kind of too obvious, please remove


for s.Scan() {
processEntry(s.Bytes(), logger)
}
Expand All @@ -32,7 +34,6 @@ func ForwardLogs(logPipe io.ReadCloser) chan error {
// The only error we want to return is when reading from
// logPipe has failed.
done <- s.Err()
close(done)
}()

return done
Expand Down
Loading