Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logs.go fixed logger creation #4250

Closed
wants to merge 1 commit into from
Closed

logs.go fixed logger creation #4250

wants to merge 1 commit into from

Conversation

AntonMoryakov
Copy link

No description provided.

kolyshkin
kolyshkin reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I guess you're fixing the case when done channel is not closed when logPipe.Close() returns an error?

Can you please say so in the commit message (and also sign it, using git commit --amend -s)?

kolyshkin
kolyshkin reviewed Apr 25, 2024
View reviewed changes
libcontainer/logs/logs.go
@@ -23,6 +23,8 @@ func ForwardLogs(logPipe io.ReadCloser) chan error {
}

go func() {
defer close(done) // defer close(done) to ensure done is always closed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is kind of too obvious, please remove

@AntonMoryakov AntonMoryakov closed this by deleting the head repository Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolyshkin kolyshkin kolyshkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonMoryakov @kolyshkin