Skip to content

layer: add use of "entries" for "files" in tar #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonboulle merged 1 commit into from
Sep 9, 2016
Merged

layer: add use of "entries" for "files" in tar #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion layer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Removals are represented using "[whiteout](#whiteouts)" file entries (See [Repre

### File Types

Throughout this document section, the use of word "files" includes:
Throughout this document section, the use of word "files" or "entries" includes:
Copy link
Contributor

@wking wking Sep 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“of word” is awkward. Maybe:

Throughout this document section, the words “files” and “entries” include:

I'm also not sure about “document section”. I expect we want something scoped to the whole layer.md, not just the “File Types” h3. How about:

Throughout the layer documentation, the words “files” and “entries” include:

Copy link
Contributor

@jonboulle jonboulle Sep 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to follow this up


* regular files
* directories
Expand Down