layer: add use of "entries" for "files" in tar #282
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @stevvooe |
Member
Author
|
well, my DCO doesn't suffice for carrying your commit ... |
Contributor
|
@vbatts rewrite the commit author and force push, it is a trivial addition |
Contributor
| ### File Types | ||
|
|
||
| Throughout this document section, the use of word "files" includes: | ||
| Throughout this document section, the use of word "files" or "entries" includes: |
Contributor
There was a problem hiding this comment.
“of word” is awkward. Maybe:
Throughout this document section, the words “files” and “entries” include:
I'm also not sure about “document section”. I expect we want something scoped to the whole layer.md, not just the “File Types” h3. How about:
Throughout the layer documentation, the words “files” and “entries” include:
Contributor
There was a problem hiding this comment.
I am going to follow this up
Contributor
Signed-off-by: Vincent Batts <[email protected]>
Member
Author
|
the "Allow edits from maintainers" is already checked. updated the Author. |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Batts [email protected]