Repository navigation
chore(deps-dev): bump jsdom from 29.1.1 to 30.1.2 - #3864
dependabot[bot] wants to merge 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
|
Codex review: needs changes before merge. What this changesThis PR upgrades the development-only jsdom dependency from 29.1.1 to 30.1.2 and refreshes its locked dependencies. Example: A jsdom XMLHttpRequest sends GET data:text/plain,hello.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Needs changes before merge - 1 item remains Keep this PR open: main still uses jsdom 29.1.1, and the proposed upgrade retains the previously reported transport incompatibility. Priority: P3 Before merge
Findings
Provenance
Tests
Agent review detailsHow this fits togetherVitest uses jsdom as its default browser environment; jsdom delegates XMLHttpRequest operations to an Undici dispatcher, while workspace dependency overrides determine the installed transport version. flowchart TD
A[Workspace dependency pins] --> B[Bun dependency resolution]
B --> C[Vitest browser environment]
C --> D[jsdom XMLHttpRequest]
D --> E[jsdom dispatcher]
E --> F[Undici request callbacks]
Technical reviewBest possible solution: Resolve jsdom 30 with a supported Undici transport while preserving the CLI's patched Undici 7 dependency and Node compatibility. Do we have a high-confidence way to reproduce the issue? The transport failure is source-reproducible: XMLHttpRequest awaits Undici request(), but jsdom 30 emits callback names absent from the resolved Undici 7 handler; no target code was executed. Is this the best way to solve the issue? The dependency upgrade is useful, but its current resolution is incorrect; separating supported transport versions is safer than globally upgrading the CLI transport or adding an application-level workaround. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 5e8aec56d146. Provenance checked
TestingProof path: none. SecurityNone. EvidenceAcceptance criteria:
What I checked:
Review metrics
LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (34 earlier review cycles; latest 8 shown)
Reviewed October 13, 2026, 12:44 PM ET / 16:44 UTC (Revision 35). |
Bumps [jsdom](https://github.com/jsdom/jsdom) from 29.1.1 to 30.1.2. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v29.1.1...v30.1.2) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
d0e5af6 to
3bac790
Compare
|
Superseded by #3943. |
Bumps jsdom from 29.1.1 to 30.1.2.
Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
a23bfb730.1.264a75d2Update dependencies and dev dependencies7bf9653Invalidate styles after CSSOM and control state changesfe9009cUpdate focused area handlinga8d28b3Release windows retained by stylesheet parsing05a2c01Deduplicate generated CSS property metadata1efa190Reduce generated CSS property dataa372e12Avoid Document named-property rebuilds after irrelevant tree mutationsb2cd235Update css-color0542d2bRelease idle MutationObserver bookkeeping